Migrate Kubelet --container-runtime-endpoint to kubelet.config.k8s.io or remove the flag

[mtaufen]

Flag name: container-runtime-endpoint

Help text:

[Experimental] The endpoint of remote runtime service. Currently unix socket is supported on Linux, and tcp is supported on windows. Examples:'unix:///var/run/dockershim.sock', 'tcp://localhost:3735'

---

This is part of migrating the Kubelet command-line to a Kubernetes-style API.

The --container-runtime-endpoint flag should either be migrated to the Kubelet's kubelet.config.k8s.io
API group, or simply removed from the Kubelet.

If this could be considered an instance-specific flag, or a descriptor of local topology
managed by the Kubelet, see: #61647.

If this flag is only registered in os-specific builds, see: #61649.

As --container-runtime-endpoint is an alpha/experimental flag, the feature it configures must either be
feature-gated, or graduated from alpha/experimental status prior to the migration.

@sig-node-pr-reviews @sig-node-api-reviews

/assign @mtaufen
/sig node
/kind feature
/priority important-soon
/milestone v1.11
/status approved-for-milestone

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Issue Needs Attention

@mtaufen @yujuhong @kubernetes/sig-node-misc

Action required: During code slush, issues in the milestone should be in progress.
If this issue is not being actively worked on, please remove it from the milestone.
If it is being worked on, please add the status/in-progress label so it can be tracked with other in-flight issues.

Note: If this issue is not resolved or labeled as priority/critical-urgent by Tuesday, June 5th it will be moved out of the v1.11 milestone.

Issue Labels

• sig/node: Issue will be escalated to these SIGs if needed.
• priority/important-soon: Escalate to the issue owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
• kind/feature: New functionality.

Help

• Additional instructions
• Commands for setting labels

[mtaufen]

/milestone clear

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[SmileSees]

Hi @mtaufen , I was using --container-runtime-endpoint flag to integrate kubelet with containerd with k8s version 1.10.7.
And I want to upgrade k8s version to 1.11.3, similarly I am using --container-runtime-endpoint flag, but the kubelet service won't start, says:

Unknown lvalue '--runtime-cgroups' in section 'Service'

Unknown lvalue '--container-runtime-endpoint' in section 'Service'

Can you pls tell what is the replacement of this flag? Or how can I integrate kubelet with containerd at k8s 1.11.3 version?

[mtaufen]

The flag has not been removed from any Kubernetes version yet, so maybe that error is coming from somewhere else?

https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/options/options.go#L379

[SmileSees]

Thanks @mtaufen, it seems to be the character encoding cause the issue. It is ok now.

[PatrickLang]

FYI - #69516 adds npipe support (similar to a unix socket) for Windows

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[mtaufen]

/remove-lifecycle rotten /lifecycle frozen

…

On Wed, Nov 14, 2018 at 10:31 AM fejta-bot ***@***.***> wrote: Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Send feedback to sig-testing, kubernetes/test-infra and/or fejta <https://github.com/fejta>. /lifecycle rotten — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61674 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3JwV0i2Ln9YsX2CP-E2LWLOe0ezII_ks5uvGGHgaJpZM4S6V7X> .

-- Michael Taufen Google SWE

[swatisehgal]

/triage accepted
/area kubelet

[ehashman]

SIG Node Bug Scrub has decided to close the 23 individual flag tracking issues in favour of using the unified tracker in #86843. We will list each issue here that we're closing and the associated flag.

/close

[k8s-ci-robot]

@ehashman: Closing this issue.

In response to this:

SIG Node Bug Scrub has decided to close the 23 individual flag tracking issues in favour of using the unified tracker in #86843. We will list each issue here that we're closing and the associated flag.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.