Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch windows runtime endpoints to npipe #69516
What this PR does / why we need it:
Switch default windows runtime endpoints to npipe. tcp endpoints are also supported for backward compatibility.
Which issue(s) this PR fixes (optional, in
Special notes for your reviewer:
@Random-Liu @feiskyer - I am totally fine supporting only
protocol, addr, err := parseEndpoint("npipe://./pipe/mypipe") // protocol == "npipe" // addr == "\\\\.\\pipe\\mypipe"
We need to return
@feiskyer - Your change looks good. Two questions:
This was referenced
Oct 15, 2018
@yujuhong: GitHub didn't allow me to request PR reviews from the following users: pjh.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
Okay with the overall approach. Would like a windows folk to review the npipe path parsing
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here