Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet doesn't report ExternalIP/DNS with --node-ip #63158

Closed
micahhausler opened this issue Apr 25, 2018 · 0 comments · Fixed by #63170
Closed

Kubelet doesn't report ExternalIP/DNS with --node-ip #63158

micahhausler opened this issue Apr 25, 2018 · 0 comments · Fixed by #63170
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@micahhausler
Copy link
Member

micahhausler commented Apr 25, 2018 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

When using the --node-ip flag on the kubelet, the node's .status.addresses list no longer reports ExternalDNS, InternalDNS, ExternalIP addresses.

What you expected to happen:

That I can explicitly set --node-ip to an IP, but the other addresses will still show up.

How to reproduce it (as minimally and precisely as possible):

Create a new kops cluster, modify the kubelet to use the --node-ip flag with the eth0 on the node. Run kubectl get no <node-name> -o json | jq .status.addresses

Anything else we need to know?:

This change will probably take place in Kubelet.setNodeAddresses()

This came up as a result of #61921

Environment:

  • Kubernetes version (use kubectl version): 1.9.x
  • Cloud provider or hardware configuration: AWS
  • OS (e.g. from /etc/os-release): any
  • Kernel (e.g. uname -a): any
  • Install tools: kops

/sig network
/sig node

@andrewsykim
@nckturner

I'll make a PR for this change shortly
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 25, 2018
@micahhausler micahhausler mentioned this issue Apr 25, 2018
Closed
@micahhausler micahhausler mentioned this issue Apr 25, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue May 11, 2018
Merge pull request #63170 from micahhausler/node-ip-fix
6017f6d 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Report node DNS info with --node-ip

**What this PR does / why we need it**:
This PR adds `ExternalDNS`, `InternalDNS`, and `ExternalIP` info for kubelets with the `--nodeip` flag enabled. 

**Which issue(s) this PR fixes** 
Fixes #63158

**Special notes for your reviewer**:

I added a field to the Kubelet to make IP validation more testable (`validateNodeIP` relies on the `net` package and the IP address of the host that is executing the test.) I also converted the test to use a table so new cases could be added more easily.

**Release Notes**
```release-note
Report node DNS info with --node-ip flag
```

@andrewsykim
@nckturner 

/sig node
/sig network
@micahhausler micahhausler mentioned this issue Oct 9, 2018
Closed
@flokli flokli mentioned this issue Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report node DNS info with --node-ip micahhausler/kubernetes
2 participants
@micahhausler @k8s-ci-robot