-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Default Admission Controllers for Storage #64295
Comments
What do you mean by this? |
I think @saad-ali meant that we should audit and make sure that features which are enabled by default and depend on certain admission controller, also have the required admission controller enabled by default. For example - We are moving volume expansion to beta in 1.11 (#64288 ) and hence resize admission controller should be enabled by default. |
Basically ensure that the correct set of storage admission controllers are enabled. |
Yes, I think we can make it default enabled once beta. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
PR #58684 adds a set of Admission Controllers that are on by default.
What you expected to happen:
We should make sure that list of controllers makes sense for storage.
Storage controllers include:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):uname -a
):The text was updated successfully, but these errors were encountered: