Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vshere cloud provider on the controller-manager fails to start on non-vmware hosts #65145

Closed
alvaroaleman opened this issue Jun 15, 2018 · 3 comments · Fixed by #65152
Closed

Vshere cloud provider on the controller-manager fails to start on non-vmware hosts #65145

alvaroaleman opened this issue Jun 15, 2018 · 3 comments · Fixed by #65152
Labels
area/provider/vmware Issues or PRs related to vmware provider kind/bug Categorizes issue or PR as related to a bug.

Comments

@alvaroaleman
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

What happened:

Currently the vsphere cloud provider blocks the controller-manager from running if its running on a non-vmware host, because it reads /sys/class/dmi/id/product_serial and checks if its content starts with VMWARE-.

What you expected to happen:

The controller manager to start

How to reproduce it (as minimally and precisely as possible):

Start a controller-manager on a non-vmware environment with the --cloud-provider vsphere --cloud-config /my/cloud/conf flags set

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Jun 15, 2018
@alvaroaleman
Copy link
Member Author

/sig vmware

@k8s-ci-robot k8s-ci-robot added area/provider/vmware Issues or PRs related to vmware provider and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 15, 2018
@alvaroaleman alvaroaleman mentioned this issue Jun 15, 2018
Merged
@prashima
Copy link
Contributor

@alvaroaleman can you please share some more context- Why do you want vSphere cloud provider to work with non-vmware host (I believe you mean ESXi)? Where is this requirement coming from.

@alvaroaleman
Copy link
Member Author

@prashima We are building a Kubernetes cluster management solution which does Kubernetes in Kubernetes and works by creating the control planes in one cluster, then creating worker instances on one of the supported platforms, among them vsphere.

Currently the cluster hosting the control planes (We call it seed cluster) has to run on ESXi, otherwise the controller-manager crashes.

Having the check in place for the Kubelets is completely fine and definitely makes sense, but for the controller-manager it should IMHO not be required.

k8s-github-robot pushed a commit that referenced this issue Jun 22, 2018
Merge pull request #65152 from alvaroaleman/vsphere-control-plane-on-…
af1450d 
…cloud

Automatic merge from submit-queue (batch tested with PRs 65152, 65199, 65179, 64598, 65216). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Do not query for VMUUID in vsphere cloud provider if it was explicitly passed

**What this PR does / why we need it**:

It allows running the kube controller-manager with the vsphere cloudprovider enabled on a machine that is not a vmware VM

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #65145

**Special notes for your reviewer**:

**Release note**:

```release-note
In the vSphere cloud provider the `Global.vm-uuid` configuration option is not deprecated anymore, it can be used to overwrite the VMUUID on the controller-manager
```

/sig vmware
@alvaroaleman alvaroaleman mentioned this issue Oct 11, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/provider/vmware Issues or PRs related to vmware provider kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
3 participants
@alvaroaleman @k8s-ci-robot @prashima