Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl: Drop backOff from DrainOptions #66266

Merged
merged 1 commit into from
Oct 5, 2018
Merged

kubectl: Drop backOff from DrainOptions #66266

merged 1 commit into from
Oct 5, 2018

Conversation

wking
Copy link
Contributor

@wking wking commented Jul 17, 2018 •
edited

The property was added in b73fae6 (#35483), but b358b2d (#37604) removed the last consumer. CC @mengqiy, who authored both of those PRs.

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 17, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 17, 2018
@wking wking mentioned this pull request Jul 17, 2018
Merged
@mengqiy
Copy link
Member

mengqiy commented Jul 18, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 18, 2018
@mengqiy
Copy link
Member

mengqiy commented Jul 18, 2018

I guess you may also need to update the BUILD file

@wking wking force-pushed the kubectl-drain-drop-backOff branch from 275fef2 to 7b8b110 Compare July 18, 2018 19:00
@wking
Copy link
Contributor Author

wking commented Jul 18, 2018

I guess you may also need to update the BUILD file

Oh, right. Done with 275fef2 -> 7b8b110.

@wking
Copy link
Contributor Author

wking commented Jul 18, 2018

@mengqiy, can I get a /retest? On the off chance I can trigger it myself:

/retest

@seans3
Copy link
Contributor

seans3 commented Sep 24, 2018

@wking Please type the following from the top-level dir:

hack/update-bazel.sh

which should update one or more BUILD files. Please commit these changes and we'll retest.

@wking
kubectl: Drop backOff from DrainOptions
ab993e3 
The property was added in b73fae6 (Fix kubectl drain for statefulset
and use eviciton for drain if possible, 2016-10-20, kubernetes#35483), but
b358b2d (make drain retry forever and use new timeout,
2016-11-28, kubernetes#37604) removed the last consumer.
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Sep 24, 2018
@wking
Copy link
Contributor Author

wking commented Sep 24, 2018 •
edited

Rebased onto master and rebuilt the BUILD with 7b8b110 -> ab993e3. I dunno why I'd been removing clockwork from BUILD before (from this comment, it seems like it was needed by previous test failures?), but the new reroll leaves the BUILD alone.

soltysh
soltysh approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@soltysh
Copy link
Contributor

soltysh commented Oct 4, 2018

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit fecb5ed into kubernetes:master Oct 5, 2018
@wking wking deleted the kubectl-drain-drop-backOff branch October 5, 2018 02:56
@wking wking mentioned this pull request Jan 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@ericchiang ericchiang Awaiting requested review from ericchiang

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wking @mengqiy @seans3 @k8s-ci-robot @soltysh @fejta-bot