Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cAdvisor godeps to v0.31.0 #68431

Merged
merged 1 commit into from Sep 12, 2018
Merged

Update cAdvisor godeps to v0.31.0 #68431

merged 1 commit into from Sep 12, 2018

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Sep 8, 2018

What this PR does / why we need it:
Update the cAdvisor dependency for the 1.12 release.

Special notes for your reviewer:
Some of the interfaces of cAdvisor changed this release. The values used here maintain the previous behavior.

This PR adds a few new new vendored dependencies that were added as part of adding mesos containerizer support. All new dependencies have Apache 2.0 licenses.

Release note:

- cAdvisor: Fix NVML initialization race condition
- cAdvisor: Fix brtfs filesystem discovery
- cAdvisor: Fix race condition with AllDockerContainers
- cAdvisor: Don't watch .mount cgroups
- cAdvisor: Reduce lock contention during list containers

/assign @dchen1107 @thockin

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2018
@dashpole
Copy link
Contributor Author

dashpole commented Sep 8, 2018

/sig node
/priority critical-urgent
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/bug Categorizes issue or PR as related to a bug. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 8, 2018
@dashpole
Copy link
Contributor Author

dashpole commented Sep 8, 2018

apologies for letting this slip so late. Thanks to @bboreham for reminding us.

@dchen1107
Copy link
Member

/retest

@dchen1107
Copy link
Member

cc/ @derekwaynecarr

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2018
@dashpole
Copy link
Contributor Author

/retest

@thockin
Copy link
Member

thockin commented Sep 10, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, dchen1107, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtaufen mtaufen added this to the v1.12 milestone Sep 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit 37ef6ee into kubernetes:master Sep 12, 2018
@dashpole dashpole deleted the cadvisor_godep_update branch January 15, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@resouer resouer Awaiting requested review from resouer

Assignees

@thockin thockin

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dashpole @dchen1107 @thockin @k8s-ci-robot @mtaufen