Push the CoreDNS 1.2.3 image in gcr.io

[rajansandeep]

Need to push the latest CoreDNS image to gcr.io
The 1.2.3 image is available in docker coredns/coredns:1.2.3

This is the script used for pushing the image:

#!/bin/sh

if [ -z "$1" -o -z "$2" -o -z "$3" -o -z "$4" ]; then
    echo "usage: $0 <src-reg> <image> <tag> <dst-reg>" > /dev/stderr
    echo "example: $0 coredns coredns 1.2.3 staging-k8s.gcr.io" > /dev/stderr
    exit 1
fi

SRC_REG="$1"
IMG="$2"
TAG="$3"
DST_REG="$4"
TMP="/tmp/$RANDOM"
JSON="$TMP.json"

echo "Fetching source manifest"
docker manifest inspect ${SRC_REG}/${IMG}:${TAG} > ${JSON}

echo
echo "Pulling source images by SHA"
cat ${JSON} \
    | jq -j ".manifests[] | \"${SRC_REG}/${IMG}@\", .digest, \"\n\" " \
    | while read X; do docker pull $X; done

echo
echo "Tagging images with ARCH and OS"
cat ${JSON} \
    | jq -j ".manifests[] | \"docker tag ${SRC_REG}/${IMG}@\", .digest, \" ${DST_REG}/${IMG}:${TAG}__\", .platform.architecture, \"_\", .platform.os, \"\n\"" \
    | while read X; do $X; done

echo
echo "Pushing images"
cat ${JSON} \
    | jq -j ".manifests[] | \"gcloud docker -- push ${DST_REG}/${IMG}:${TAG}__\", .platform.architecture, \"_\", .platform.os, \"\n\"" \
    | while read X; do $X; done

echo
echo "Creating and pushing manifest"
PLATFORMS=$(cat ${JSON} | jq -j ".manifests[] | .platform.os, \"/\", .platform.architecture, \"\n\"" | paste -sd,)
echo manifest-tool push from-args \
    --platforms "${PLATFORMS}" \
    --template ${DST_REG}/${IMG}:${TAG}__ARCH_OS \
    --target ${DST_REG}/${IMG}:${TAG}
manifest-tool push from-args \
    --platforms "${PLATFORMS}" \
    --template ${DST_REG}/${IMG}:${TAG}__ARCH_OS \
    --target ${DST_REG}/${IMG}:${TAG}

/cc @chrisohaver
/cc @BenTheElder
/cc @timothysc
/assign @thockin

@fturib

/sig network
/sig cluster-lifecycle
/sig release

[rajansandeep]

/cc @AishSundar

[fturib]

This release CoreDNS 1.2.3 includes optimization for the scale tests.
We need it to be pushed to gcr.io in order to run CoreDNS in Kubernetes and be able to finish validating that 5k nodes scale test is now good.

Thanks to push this image asap.

[dims]

cc @ixdy @fejta (since Erick is on call)

[thockin]

I will kick this off.

…

On Tue, Oct 16, 2018 at 7:32 AM Sandeep Rajan ***@***.***> wrote: Need to push the latest CoreDNS image to gcr.io The 1.2.3 image is available in docker coredns/coredns:1.2.3 This is the script used for pushing the image: #!/bin/sh if [ -z "$1" -o -z "$2" -o -z "$3" -o -z "$4" ]; then echo "usage: $0 <src-reg> <image> <tag> <dst-reg>" > /dev/stderr echo "example: $0 coredns coredns 1.2.3 staging-k8s.gcr.io" > /dev/stderr exit 1 fi SRC_REG="$1" IMG="$2" TAG="$3" DST_REG="$4" TMP="/tmp/$RANDOM" JSON="$TMP.json" echo "Fetching source manifest" docker manifest inspect ${SRC_REG}/${IMG}:${TAG} > ${JSON} echo echo "Pulling source images by SHA" cat ${JSON} \ | jq -j ".manifests[] | \"${SRC_REG}/${IMG}@\", .digest, \"\n\" " \ | while read X; do docker pull $X; done echo echo "Tagging images with ARCH and OS" cat ${JSON} \ | jq -j ".manifests[] | \"docker tag ${SRC_REG}/${IMG}@\", .digest, \" ${DST_REG}/${IMG}:${TAG}__\", .platform.architecture, \"_\", .platform.os, \"\n\"" \ | while read X; do $X; done echo echo "Pushing images" cat ${JSON} \ | jq -j ".manifests[] | \"gcloud docker -- push ${DST_REG}/${IMG}:${TAG}__\", .platform.architecture, \"_\", .platform.os, \"\n\"" \ | while read X; do $X; done echo echo "Creating and pushing manifest" PLATFORMS=$(cat ${JSON} | jq -j ".manifests[] | .platform.os, \"/\", .platform.architecture, \"\n\"" | paste -sd,) echo manifest-tool push from-args \ --platforms "${PLATFORMS}" \ --template ${DST_REG}/${IMG}:${TAG}__ARCH_OS \ --target ${DST_REG}/${IMG}:${TAG} manifest-tool push from-args \ --platforms "${PLATFORMS}" \ --template ${DST_REG}/${IMG}:${TAG}__ARCH_OS \ --target ${DST_REG}/${IMG}:${TAG} /cc @chrisohaver /cc @BenTheElder /cc @timothysc /assign @thockin @fturib /sig network /sig cluster-lifecycle /sig release — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

[thockin]

Promoter will run shortly

[dims]

Dang! problem with 1.2.3 version, details:

• Make CoreDNS default in kubeup and update CoreDNS version/manifest in kubeup and kubeadm #69883 (comment)
• V1.2.3 error in log: expected type *object.Service, but watch event object had type *v1.Service coredns/coredns#2204

[fturib]

Yes, unfortunately, we will have to fix, re-validate and release another version of CoreDNS.
(and extend our CI as this issue went through it)

For the coreDNS 1.2.3 image in gcr.io, I am not sure what is usual behavior.
Is it safer to delete it ? (sorry about that)

[thockin]

How can we get moe confidence in releases in staging before being promoted?

…

On Wed, Oct 17, 2018, 11:29 AM Francois Tur ***@***.*** wrote: Yes, unfortunately, we will have to fix, re-validate and release another version of CoreDNS. (and extend our CI as this issue went through it) For the coreDNS 1.2.3 image in gcr.io ***@***.***:12f3cab301c826978fac736fd40aca21ac023102fd7f4aa6b4341ae9ba89e90e>, I am not sure what is usual behavior. Is it safer to delete it ? (sorry about that) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#69880 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVLlXc47RK35Ooozy7Aryf6SIQf2-ks5ul3cAgaJpZM4XefZE> .

[chrisohaver]

How can we get moe confidence in releases in staging before being promoted?

We are adding tests to the CoreDNS CI for this case.

[chrisohaver]

How can we get moe confidence in releases in staging before being promoted?

Actually, we could run coredns build candidates through the K8s e2e test infra, in a test PR that points to docker-hub coredns build. We should start doing this before pushing the build to staging.

Will do that before requesting push of next build.

[AishSundar]

do we need to do anything to undo the buggy image that was pushed? @fturib and @chrisohaver should we expect any blip in the CI signal?

[chrisohaver]

should we expect any blip in the CI signal?

@AishSundar, Nothing in the tests uses the new image yet. So I don't think tests would be affected.

[thockin]

Bugs happen, I am not too worried about that - we don't typically nuke buggy versions. Ping me when a new one is ready.

…

On Wed, Oct 17, 2018 at 2:17 PM chrisohaver ***@***.***> wrote: should we expect any blip in the CI signal? @AishSundar <https://github.com/AishSundar>, Nothing in the tests uses the new image yet. So I don't think tests would be affected. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#69880 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFVgVPRbec9QMlR_ML2IfPbZa_Dygipqks5ul55UgaJpZM4XefZE> .