Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch kubectl rollout to directly rolling back deployments #70039

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Switch kubectl rollout to directly rolling back deployments #70039

merged 1 commit into from
Oct 30, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Oct 19, 2018 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes kubectl use of the extensions/v1beta1 rollback API, which is deprecated and removed in apps/v1. This is a prereq of switching to apps/v1 completely and stopping serving the extensions/v1beta1 API.

Also correctly returns error codes when trying to rollback a deployment to a non-existent revision

xref #43214

Does this PR introduce a user-facing change?:

`kubectl rollout undo` now returns errors when attempting to rollback a deployment to a non-existent revision
`kubectl rollout undo` no longer uses the deprecated extensions/v1beta1 rollback API, which means that Events are no longer emitted when rolling back a deployment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2018
@liggitt
Copy link
Member Author

liggitt commented Oct 19, 2018

cc @janetkuo @seans3 @soltysh

@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 19, 2018
@liggitt liggitt added sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed area/kubectl labels Oct 19, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@soltysh soltysh mentioned this pull request Oct 19, 2018
Closed
41 tasks
@kow3ns
Copy link
Member

kow3ns commented Oct 19, 2018

/assign @janetkuo

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 20, 2018
@liggitt liggitt added the kind/bug Categorizes issue or PR as related to a bug. label Oct 20, 2018
@liggitt liggitt added this to the v1.13 milestone Oct 23, 2018
@janetkuo
Copy link
Member

janetkuo commented Oct 24, 2018 •
edited

Another user visible change is that rollback no longer emits events. Worth mentioning in the release note.

@liggitt
Copy link
Member Author

liggitt commented Oct 25, 2018

comments addressed

soltysh
soltysh approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'll let Janet have final saying

/cc @tnozicka

krmayankk
krmayankk reviewed Oct 26, 2018
View reviewed changes
pkg/kubectl/rollback.go Outdated Show resolved Hide resolved
janetkuo
janetkuo reviewed Oct 26, 2018
View reviewed changes
pkg/kubectl/rollback.go Outdated Show resolved Hide resolved
pkg/kubectl/rollback.go Outdated Show resolved Hide resolved
pkg/kubectl/rollback.go Outdated Show resolved Hide resolved
pkg/kubectl/util/deployment/deployment.go Outdated Show resolved Hide resolved
pkg/kubectl/rollback.go Outdated Show resolved Hide resolved
@liggitt
Copy link
Member Author

liggitt commented Oct 27, 2018

updated

@janetkuo
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2018
@k8s-ci-robot k8s-ci-robot merged commit 975e6c0 into kubernetes:master Oct 30, 2018
@liggitt liggitt deleted the deployment-rollback branch October 30, 2018 04:57
@pacoxu pacoxu mentioned this pull request Dec 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmayankk krmayankk krmayankk left review comments

@soltysh soltysh soltysh approved these changes

@janetkuo janetkuo janetkuo approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@eparis eparis Awaiting requested review from eparis

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @kow3ns @k8s-ci-robot @janetkuo @soltysh @krmayankk