Prune all kubeapiserver internal informer/lister codes from k/k #70217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
|
nice cleanup! I wonder if we can remove the internal clients as well. |
|
@liggitt yuh huh. about to. i just tried that locally but it involves larger changes than i thought. will do it in another pull 😉 |
|
cc @yliaog |
yue9944882
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve Though it will need higher level approval. |
|
/lgtm |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
yue9944882
force-pushed
the
prune-internal-informer-lister-from-kk
branch
from
0886a93
to
50d6f7c
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
yue9944882
force-pushed
the
prune-internal-informer-lister-from-kk
branch
from
50d6f7c
to
efeec1e
Compare
|
/approve This is awesome!!! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, lavalamp, yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the hub/internal object types is only used thru the handler chain. now we remove internal informers/listers to restrict that usage.
@kubernetes/sig-api-machinery-misc
Does this PR introduce a user-facing change?: