Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune internal aggregator client/informer/ from aggregator #69683

Closed
wants to merge 3 commits into from
Closed

Prune internal aggregator client/informer/ from aggregator #69683

wants to merge 3 commits into from

Conversation

yue9944882
Copy link
Member

@yue9944882 yue9944882 commented Oct 11, 2018 •
edited

/hold
/sig apimachinery
/kind cleanup

this pull will be pending until we fixes code-generating scripts #68559

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2018
@yue9944882 yue9944882 mentioned this pull request Oct 11, 2018
Merged
@yue9944882 yue9944882 force-pushed the chore/prune-internal-aggregator-client branch 3 times, most recently from dccbbb5 to b319c9a Compare October 11, 2018 15:56
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2018
@yue9944882
Copy link
Member Author

ref: #70217 (i guess?)

@sttts
Copy link
Contributor

sttts commented Oct 25, 2018

@deads2k @lavalamp @liggitt what do you think about starting removing internal clients whereever possible?

@liggitt
Copy link
Member

liggitt commented Oct 25, 2018

@deads2k @lavalamp @liggitt what do you think about starting removing internal clients whereever possible?

probably makes sense. there are few (no?) places we're still recommending they be used, and they have problems with sparse versions and cross-group subresources.

@deads2k
Copy link
Contributor

deads2k commented Oct 26, 2018

@deads2k @lavalamp @liggitt what do you think about starting removing internal clients whereever possible?

Yes, we probably should.

@yue9944882 yue9944882 changed the title [experimental] Prune internal aggregator client/informer/ from aggregator Prune internal aggregator client/informer/ from aggregator Oct 29, 2018
@yue9944882 yue9944882 force-pushed the chore/prune-internal-aggregator-client branch from b319c9a to cb3d51d Compare November 5, 2018 07:27
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 5, 2018
@yue9944882
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2018
@yue9944882 yue9944882 force-pushed the chore/prune-internal-aggregator-client branch 3 times, most recently from 5708ec3 to dc10374 Compare November 5, 2018 07:57
@yue9944882 yue9944882 force-pushed the chore/prune-internal-aggregator-client branch 4 times, most recently from e113c3e to 76cf21a Compare November 5, 2018 09:28
@sttts
Copy link
Contributor

sttts commented Nov 5, 2018

verify is unhappy

@yue9944882 yue9944882 force-pushed the chore/prune-internal-aggregator-client branch from 76cf21a to 8f7c986 Compare November 5, 2018 12:14
@yue9944882
Copy link
Member Author

/assign @sttts

it's now happy for a review 👌🏻

@yue9944882 yue9944882 mentioned this pull request Nov 5, 2018
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yue9944882
Copy link
Member Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@yue9944882: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 25, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yue9944882
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@yue9944882: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 8f7c986 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-100-performance 8f7c986 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-kubemark-e2e-gce-big 8f7c986 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-bazel-test 8f7c986 link /test pull-kubernetes-bazel-test
pull-kubernetes-dependencies 8f7c986 link /test pull-kubernetes-dependencies
pull-kubernetes-node-e2e 8f7c986 link /test pull-kubernetes-node-e2e
pull-kubernetes-verify 8f7c986 link /test pull-kubernetes-verify
pull-kubernetes-bazel-build 8f7c986 link /test pull-kubernetes-bazel-build
pull-kubernetes-integration 8f7c986 link /test pull-kubernetes-integration
pull-kubernetes-typecheck 8f7c986 link /test pull-kubernetes-typecheck
pull-kubernetes-e2e-gce-device-plugin-gpu 8f7c986 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yue9944882 yue9944882 mentioned this pull request Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako Awaiting requested review from cheftako

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sttts sttts

Labels
area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yue9944882 @sttts @liggitt @deads2k @fejta-bot @k8s-ci-robot