fix aws provider to handle only EBS volumes #70432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/ok-to-test Looks right - thanks @mvladev /lgtm |
k8s-ci-robot
added
lgtm
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nill reference error. fixes kubernetes#68996
mvladev
force-pushed
the
fix-cloud-provider-aws
branch
from
7f33f25
to
fa80dd5
Compare
k8s-ci-robot
removed
the
lgtm
|
@justinsb updated bazel |
|
That'll teach you to try to add tests @mvladev ;-) /lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
This was referenced Oct 31, 2018
k8s-ci-robot
added
release-note
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mvladev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Probably we shouldn't merge before #70533 though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nil pointer dereference error.
Which issue(s) this PR fixes:
Fixes #68996
Special notes for your reviewer:
I'll fix
OpenStackandGCEin subsequent PR.Does this PR introduce a user-facing change?:
/sig cloud-provider
/sig aws