New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix openstack provider to handle only Cinder volumes #70459

Merged
merged 1 commit into from Oct 31, 2018

Conversation

@mvladev
Contributor

mvladev commented Oct 31, 2018

What type of PR is this?
/kind bug

What this PR does / why we need it:
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nil pointer dereference error.

Which issue(s) this PR fixes:
openstack variant of #68996

Special notes for your reviewer:
This the OpenStack variant of #70432 .

Does this PR introduce a user-facing change?:

Fix cloud-controller-manager crash when using OpenStack provider and PersistentVolume initializing controller  

/sig cloud-provider
/sig openstack

fix openstack provider to handle only Cinder volumes
When the cloud-controller-manager is running with PV label initializing controller
and NFS volume is created, it causes nill reference error.

related to #68996
@mvladev

This comment has been minimized.

Contributor

mvladev commented Oct 31, 2018

/assign @NickrenREN

@idealhack

This comment has been minimized.

Member

idealhack commented Oct 31, 2018

/ok-to-test

@NickrenREN

This comment has been minimized.

Member

NickrenREN commented Oct 31, 2018

LGTM, thanks @mvladev

/approve

BTW: could you add UTs for openstack too just like you did for aws and gce ?
also can you send you PR here https://github.com/kubernetes/cloud-provider-openstack too ?

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 31, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvladev, NickrenREN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adisky

This comment has been minimized.

adisky commented Oct 31, 2018

lgtm

@mvladev

This comment has been minimized.

Contributor

mvladev commented Oct 31, 2018

@NickrenREN

BTW: could you add UTs for openstack too just like you did for aws and gce ?

I've been looking at this, but it seems that there are no UT at all in this provider - all tests require real OpenStack installation to test. Couldn't find any mock / fake clients to do so.

also can you send you PR here https://github.com/kubernetes/cloud-provider-openstack too ?

Of course.

@NickrenREN

This comment has been minimized.

Member

NickrenREN commented Oct 31, 2018

sgtm, thanks @mvladev

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Oct 31, 2018

@k8s-ci-robot k8s-ci-robot merged commit 0325662 into kubernetes:master Oct 31, 2018

18 checks passed

cla/linuxfoundation mvladev authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details

@mvladev mvladev deleted the mvladev:fix-cloud-provider-openstack branch Oct 31, 2018

k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018

Merge pull request #70479 from mvladev/automated-cherry-pick-of-#70459-…
…upstream-release-1.10

Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes

k8s-ci-robot added a commit that referenced this pull request Nov 1, 2018

Merge pull request #70487 from mvladev/automated-cherry-pick-of-#70459-…
…upstream-release-1.12

Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment