-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix openstack provider to handle only Cinder volumes #70459
fix openstack provider to handle only Cinder volumes #70459
Conversation
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nill reference error. related to kubernetes#68996
/assign @NickrenREN |
/ok-to-test |
LGTM, thanks @mvladev /approve BTW: could you add UTs for openstack too just like you did for aws and gce ? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mvladev, NickrenREN The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lgtm |
I've been looking at this, but it seems that there are no UT at all in this provider - all tests require real OpenStack installation to test. Couldn't find any mock / fake clients to do so.
Of course. |
sgtm, thanks @mvladev /lgtm |
…9-upstream-release-1.10 Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
…9-upstream-release-1.12 Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
…9-upstream-release-1.11 Automated cherry pick of #70459: fix openstack provider to handle only Cinder volumes
What type of PR is this?
/kind bug
What this PR does / why we need it:
When the cloud-controller-manager is running with PV label initializing controller and NFS volume is created, it causes nil pointer dereference error.
Which issue(s) this PR fixes:
openstack variant of #68996
Special notes for your reviewer:
This the
OpenStack
variant of #70432 .Does this PR introduce a user-facing change?:
/sig cloud-provider
/sig openstack