Graduate Kubelet plugin registration/watcher to GA

[vladimirvivien]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR contains code changes necessary to graduate the Kubelet Plugin Watcher registration mechanism from Beta to GA

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70484

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

The Kubelet plugin registration mechanism used by device plugins and CSI plugins is now GA

[vladimirvivien]

/sig node

cc @RenaudWasTaken

[vladimirvivien]

/retest

[vladimirvivien]

/retest

[vladimirvivien]

@tallclair PTAL

[RenaudWasTaken]

/lgtm

Though I'm not sure why the Kubelet struct needed to be reformated?

[vladimirvivien]

@RenaudWasTaken thanks for review, not sure why my editor reformatted code after I updated kubelet to point to v1 package. Will take a look. Thanks.

[vladimirvivien]

@vishh PTAL. Looking for approval for 1.13.

[vishh]

Hmm.. Was the switch from alpha->GA discussed early on? What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

[vladimirvivien]

@vishh Hi. This is to go from Beta -> GA. This feature has been in used for a while now. The reference to beta packages were not updated in last previous release. To answer your other questions: this API has been in used by may CSI drivers (https://kubernetes-csi.github.io/docs/Drivers.html). As CSI moves to GA this quarter, we feel this is one of the other API that could go GA as well.

cc @RenaudWasTaken

[saad-ali]

What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

This feature defines how CSI drivers are discovered. GA of this feature is a blocker CSI GA (which we are planning for this 1.13 release). It also means that once CSI goes GA the requirements from CSI for this feature are unlikely to change since CSI it self needs to remain backwards compatible and backwards incompatible changes would break CSI).

The existing API has been sufficient for CSI and we haven't changed it since alpha. The only known use cases that we are currently aware of that may require changing the API is adding windows support -- but that so far seems like it won't require any change or only additive change.

[vishh]

I was misguided by the comment which changed from alpha to GA. After chatting with @msau42 offline, I learned that the API has been put to use in the CSI world for a release now and @saad-ali is stating that the API has been sufficient since alpha. I'm more comfortable with graduating this API now.
/approve
/lgtm

[AishSundar]

/priority important-soon
/milestone v1.13

[vladimirvivien]

@vishh Please re-approve. I had to rebase.

[vladimirvivien]

@tallclair PTAL, looking for approval for this feature.

[saad-ali]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, vishh, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/features/OWNERS [saad-ali]
• pkg/kubelet/OWNERS [vishh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RenaudWasTaken]

/lgtm

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

[msau42]

/retest