New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate Kubelet plugin registration/watcher to GA #70559

Merged
merged 3 commits into from Nov 15, 2018

Conversation

@vladimirvivien
Copy link
Member

vladimirvivien commented Nov 1, 2018

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR contains code changes necessary to graduate the Kubelet Plugin Watcher registration mechanism from Beta to GA

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70484

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

The Kubelet plugin registration mechanism used by device plugins and CSI plugins is now GA
@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 1, 2018

/sig node

cc @RenaudWasTaken

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 2, 2018

/retest

1 similar comment
@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 2, 2018

/retest

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:kubelet-plugin-watcher-ga branch from a027f20 to 3120684 Nov 2, 2018

@vladimirvivien vladimirvivien referenced this pull request Nov 2, 2018

Closed

Move Kubelet Plugin Registration Watcher to GA #70484

4 of 6 tasks complete

@vladimirvivien vladimirvivien changed the title Kubelet Plugin Watcher - Changes to graduate to GA Graduate Kubelet plugin registration/watcher to GA Nov 2, 2018

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 5, 2018

@tallclair PTAL

@RenaudWasTaken
Copy link
Member

RenaudWasTaken left a comment

/lgtm

Though I'm not sure why the Kubelet struct needed to be reformated?

@k8s-ci-robot k8s-ci-robot added the lgtm label Nov 5, 2018

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 5, 2018

@RenaudWasTaken thanks for review, not sure why my editor reformatted code after I updated kubelet to point to v1 package. Will take a look. Thanks.

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 5, 2018

@vishh PTAL. Looking for approval for 1.13.

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Nov 5, 2018

Hmm.. Was the switch from alpha->GA discussed early on? What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 6, 2018

@vishh Hi. This is to go from Beta -> GA. This feature has been in used for a while now. The reference to beta packages were not updated in last previous release. To answer your other questions: this API has been in used by may CSI drivers (https://kubernetes-csi.github.io/docs/Drivers.html). As CSI moves to GA this quarter, we feel this is one of the other API that could go GA as well.

cc @RenaudWasTaken

@saad-ali

This comment has been minimized.

Copy link
Member

saad-ali commented Nov 8, 2018

What makes us believe that the existing API & behavior is what we'd like to maintain for at-least a year from now?

This feature defines how CSI drivers are discovered. GA of this feature is a blocker CSI GA (which we are planning for this 1.13 release). It also means that once CSI goes GA the requirements from CSI for this feature are unlikely to change since CSI it self needs to remain backwards compatible and backwards incompatible changes would break CSI).

The existing API has been sufficient for CSI and we haven't changed it since alpha. The only known use cases that we are currently aware of that may require changing the API is adding windows support -- but that so far seems like it won't require any change or only additive change.

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Nov 8, 2018

I was misguided by the comment which changed from alpha to GA. After chatting with @msau42 offline, I learned that the API has been put to use in the CSI world for a release now and @saad-ali is stating that the API has been sufficient since alpha. I'm more comfortable with graduating this API now.
/approve
/lgtm

@AishSundar

This comment has been minimized.

Copy link
Contributor

AishSundar commented Nov 12, 2018

/priority important-soon
/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 12, 2018

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:kubelet-plugin-watcher-ga branch from 3120684 to 1a15894 Nov 13, 2018

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:kubelet-plugin-watcher-ga branch from 1a15894 to 8f217e7 Nov 13, 2018

@vladimirvivien vladimirvivien force-pushed the vladimirvivien:kubelet-plugin-watcher-ga branch from 8f217e7 to f16d3c5 Nov 14, 2018

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 14, 2018

@vishh Please re-approve. I had to rebase.

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 14, 2018

@tallclair PTAL, looking for approval for this feature.

@saad-ali
Copy link
Member

saad-ali left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saad-ali, vishh, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RenaudWasTaken

This comment has been minimized.

Copy link
Member

RenaudWasTaken commented Nov 14, 2018

/lgtm

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Nov 15, 2018

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Nov 15, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 843a67b into kubernetes:master Nov 15, 2018

18 checks passed

cla/linuxfoundation vladimirvivien authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-e2e-kubeadm-gce Skipped
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment