Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a998514 #70811

Merged
merged 1 commit into from
Nov 9, 2018
Merged

Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a998514 #70811

merged 1 commit into from
Nov 9, 2018

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Nov 8, 2018 •
edited

Signed-off-by: Humble Chirammal hchiramm@redhat.com

What this PR does / why we need it:

Fixes #
#70802
Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 8, 2018
@humblec
Copy link
Contributor Author

humblec commented Nov 8, 2018

/assign @dims

@humblec humblec changed the title Update heketi dependencies to sha@ce150a092a34657e8ec09a867369b2bd2b1ca79e [WIP] Update heketi dependencies to sha@ce150a092a34657e8ec09a867369b2bd2b1ca79e Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2018
@humblec
Copy link
Contributor Author

humblec commented Nov 8, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 8, 2018
@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

/retest

@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

@kubernetes/sig-testing can you please validate this failure ?

@BenTheElder
Copy link
Member

sounds like a quota / cluster-up flake kubernetes/test-infra#10043
/retest

@BenTheElder
Copy link
Member

/kind cleanup
/sig release
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

Thanks @BenTheElder !

@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

@BenTheElder That helped!! Thanks!

@obnoxxx
Copy link
Contributor

obnoxxx commented Nov 9, 2018

@humblec : heketi/heketi#1419 has been merged. Upgrading to this state should be sufficient.

@humblec humblec changed the title [WIP] Update heketi dependencies to sha@ce150a092a34657e8ec09a867369b2bd2b1ca79e Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a998514 Nov 9, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2018
obnoxxx
obnoxxx approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @humblec !

@humblec humblec mentioned this pull request Nov 9, 2018
Closed
@AishSundar AishSundar mentioned this pull request Nov 9, 2018
Closed
@humblec
Update heketi dependencies to sha@558b29266ce0a873991ecfb3edc41a668a9…
92fa290 
…98514.

Fixes #
kubernetes#70802

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

@BenTheElder it looks like I am back to the quota failure , will retest help ?

@humblec
Copy link
Contributor Author

humblec commented Nov 9, 2018

/retest

@dims
Copy link
Member

dims commented Nov 9, 2018

/assign @cblecker
/assign @thockin

@thockin
Copy link
Member

thockin commented Nov 9, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2018
@shubheksha
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@AishSundar
Copy link
Contributor

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Nov 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit f49464e into kubernetes:master Nov 9, 2018
@justaugustus justaugustus mentioned this pull request Nov 14, 2018
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obnoxxx obnoxxx obnoxxx approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dims dims

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@humblec @BenTheElder @obnoxxx @dims @thockin @k8s-ci-robot @shubheksha @AishSundar @cblecker