Ensure all response object modification happens in one place #71542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make setLink and setListLink the same, and make them happen in transformResponseObject. Make those methods also responsible for ensuring an empty list. Then move outputMediaType negotiation before all other calls in the specific methods, to ensure we fail fast. Refactoring in preparation to support type conversion on watch.
k8s-ci-robot
added
release-note-none
|
/assign @liggitt |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/apiserver
sig/api-machinery
Prepare to support watch by cleaning up the conversion method and splitting out each transition into a smaller method.
4 tasks
|
/retest |
|
/cc @mbohlool |
|
|
||
| func asV1Beta1PartialObjectMetadata(result runtime.Object) (runtime.Object, error) { | ||
| if meta.IsListType(result) { | ||
| // TODO: this should be calculated earlier |
| case target.Kind == "Table" && target.GroupVersion() == metav1beta1.SchemeGroupVersion: | ||
| // TODO: relax the version abstraction | ||
| // TODO: skip if this is a status response (delete without body)? | ||
| if err := writeMetaInternalVersion(partial, statusCode, w, req, &scope, target.GroupVersion()); err != nil { |
There was a problem hiding this comment.
updateScopeForTransform in #71548 is cleaner than writeMetaInternalVersion. It's ok as long as we don't get stuck in this intermediate state.
k8s-ci-robot
added
the
lgtm
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make setLink and setListLink the same, and make them happen in transformResponseObject.
Make those methods also responsible for ensuring an empty list. Then move outputMediaType
negotiation before all other calls in the specific methods, to ensure we fail fast.
Refactoring in preparation to support type conversion on watch.
/kind cleanup