-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix smb remount issue on Windows #73661
Conversation
/pull-kubernetes-cross |
/milestone v1.14 |
add comments for doSMBMount func fix comments about smb mount
10f268c
to
660813c
Compare
/pull-kubernetes-cross |
@PatrickLang I have changed the PR according to your comments, test with |
/assign @jingxu97 |
/LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…3661-upstream-release-1.12 Automated cherry pick of #73661
…3661-upstream-release-1.11 Automated cherry pick of #73661
…3661-upstream-release-1.13 Automated cherry pick of #73661
this issue is finally fixed in 1.11.8, 1.12.6, 1.13.4, and 1.14.0 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix smb remount issue on Windows by:
Without this PR, smb remount on same windows node would fail since original mount already exists
Which issue(s) this PR fixes:
Fixes #73087
Special notes for your reviewer:
mounter.Mount
func and add following code to check whether remotepath has already been mappedDoes this PR introduce a user-facing change?:
NONE
Release note:
/sig windows
/assign @msau42 @jsafrane
cc @jingxu97