Print the involved object in the event table as resource/name #73894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The involved object is important and only some events include its name in the message. Change the `Kind` column to `Object` and print the object in `resource/name` form to allow copy and paste to `kubectl get`. Also move the source field column to the right of involved object since it is related.
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @juanvallejo |
|
/retest |
smarterclayton
added
the
sig/cli
k8s-ci-robot
added
lgtm
|
/retest |
tedyu
reviewed
Feb 13, 2019
| @@ -1385,15 +1385,21 @@ func printEvent(obj *api.Event, options printers.PrintOptions) ([]metav1beta1.Ta | |||
| firstTimestamp = translateTimestampSince(obj.FirstTimestamp) | |||
| lastTimestamp = translateTimestampSince(obj.LastTimestamp) | |||
| } | |||
| var target string | |||
| if len(obj.InvolvedObject.Name) > 0 { | |||
| target = fmt.Sprintf("%s/%s", strings.ToLower(obj.InvolvedObject.Kind), obj.InvolvedObject.Name) | |||
There was a problem hiding this comment.
I thought "%s %s" is more friendly to copy/paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The involved object is important and only some events include its
name in the message. Change the
Kindcolumn toObjectand printthe object in
resource/nameform to allow copy and pasteto
kubectl get. Also move the source field column to the rightof involved object since it is related.
/kind bug