Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Make container create, start, and stop events consistent #73892
The messages for container lifecycle events are subtly inconsistent and should be unified.
First, the field format for containers (
Second, the pulling image event has inconsistent capitalization, fix that to be sentence without punctuation.
Third, the kill container event was unnecessarily wordy and inconsistent with the create and start events. Make the following changes:
The end result is a more pleasant message for humans:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: smarterclayton
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@derekwaynecarr addressing some egregious inconsistencies among container lifecycle events - the container name in the message reads ok even in big lists (better than
1 similar comment
@smarterclayton: The following test failed, say