fix shellcheck in hack/... and pkg/... and staging/... #74205

xichengliudui · 2019-02-18T10:41:42Z

What type of PR is this?
fix shellcheck in hack/... and pkg/... and staging/...
/kind cleanup

What this PR does / why we need it:
fix shellcheck in hack/... and pkg/... and staging/...

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

xichengliudui · 2019-02-18T10:51:31Z

/assign @cblecker @lavalamp @deads2k @piosz

xichengliudui · 2019-02-18T12:08:00Z

/test pull-kubernetes-e2e-gce

…/hack/... update pull request update pull request update pull request update pull request update pull request update pull request update pull request update pull request

xichengliudui · 2019-02-19T01:24:42Z

/assign @BenTheElder

BenTheElder · 2019-02-19T01:50:05Z

staging/src/k8s.io/metrics/hack/update-codegen.sh

-${CODEGEN_PKG}/generate-groups.sh client \
+  --output-base "$(dirname "${BASH_SOURCE[0]}")/../../.." \
+  --go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt
+"${CODEGEN_PKG}"/generate-groups.sh client \


please quote the whole string for these

Thank you for your reminding. I have modified it. Thank you

BenTheElder · 2019-02-19T17:37:59Z

staging/src/k8s.io/metrics/hack/update-codegen.sh

+  --output-base "$(dirname "${BASH_SOURCE[0]}")/../../.." \
+  --go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt


and here please :-)

Has been completed.

BenTheElder

/lgtm
/approve

xichengliudui · 2019-02-20T06:30:14Z

/test pull-kubernetes-e2e-gce-100-performance

spiffxp · 2019-02-20T15:31:48Z

staging/src/k8s.io/metrics/hack/update-codegen.sh

-  --output-base "$(dirname ${BASH_SOURCE})/../../.." \
-  --go-header-file ${SCRIPT_ROOT}/hack/boilerplate.go.txt
-${CODEGEN_PKG}/generate-groups.sh client \
+  --output-base "$(dirname "${BASH_SOURCE[0]}")/../../.." \


I would pull this out into its own OUTPUT_BASE var above, so you don't have the weird nested quotes thing going on here, ie:

OUTPUT_BASE=$(dirname "${BASH_SOURCE[0]}")/../../.. #... --output-base "${OUTPUT_BASE}"

You might also consider using SCRIPT_ROOT instead of redoing the BASH_SOURCE thing.

Brother, this modification will cause additional problems.
It will look like this:

In ./staging/src/k8s.io/metrics/hack/update-codegen.sh line 35: --output-base "${OUTPUT_BASE}" ^-----------^ SC2215: This flag is used as a command name. Bad line break or missing [ .. ]? In ./staging/src/k8s.io/metrics/hack/update-codegen.sh line 36: --go-header-file "${SCRIPT_ROOT}/hack/boilerplate.go.txt" ^--------------^ SC2215: This flag is used as a command name. Bad line break or missing [ .. ]?

did I make a mistake? Do you have a detailed reply? thank you

You are likely missing \ at the end of the line above it and on the end of the line containing --output-base "${OUTPUT_BASE}"

It should look similar to this:

"${CODEGEN_PKG}/generate-internal-groups.sh" deepcopy,conversion \ k8s.io/metrics/pkg/client k8s.io/metrics/pkg/apis k8s.io/metrics/pkg/apis \ "metrics:v1alpha1,v1beta1 custom_metrics:v1beta1 external_metrics:v1beta1" \ --output-base "${OUTPUT_BASE}" \ --go-header-file "${SCRIPT_ROOT}/hack/boilerplate.go.txt"

--output-base "${OUTPUT_BASE}" \

Appear above problem.

I agree with @mrbobbytables the error really reads like a missing trailing \, shellcheck was happy with my suggested changes locally

Since I can't see the source you're running this against, my advice would be to look above your output-base and go-header-file lines

plugin/pkg/admission/imagepolicy/gencerts.sh

k8s-ci-robot · 2019-02-21T02:18:06Z

New changes are detected. LGTM label has been removed.

xichengliudui · 2019-02-21T03:11:18Z

/retest

xichengliudui · 2019-02-22T01:20:41Z

/assign @cblecker @lavalamp @deads2k @piosz

spiffxp · 2019-02-22T18:13:34Z

needs rebase

/priority important-longterm

k8s-ci-robot · 2019-02-23T09:37:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BenTheElder, xichengliudui
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xichengliudui · 2019-02-23T09:41:48Z

/retest

k8s-ci-robot · 2019-02-23T09:52:26Z

@xichengliudui: The following tests failed for commit ca2bc4b, say /retest to rerun them:

Test name	Details	Rerun command
pull-kubernetes-e2e-gce	link	`/test pull-kubernetes-e2e-gce`
pull-kubernetes-godeps	link	`/test pull-kubernetes-godeps`
pull-kubernetes-bazel-test	link	`/test pull-kubernetes-bazel-test`
pull-kubernetes-node-e2e	link	`/test pull-kubernetes-node-e2e`
pull-kubernetes-integration	link	`/test pull-kubernetes-integration`
pull-kubernetes-kubemark-e2e-gce-big	link	`/test pull-kubernetes-kubemark-e2e-gce-big`
pull-kubernetes-e2e-gce-100-performance	link	`/test pull-kubernetes-e2e-gce-100-performance`
pull-kubernetes-e2e-gce-device-plugin-gpu	link	`/test pull-kubernetes-e2e-gce-device-plugin-gpu`
pull-kubernetes-verify	link	`/test pull-kubernetes-verify`
pull-kubernetes-typecheck	link	`/test pull-kubernetes-typecheck`
pull-kubernetes-bazel-build	link	`/test pull-kubernetes-bazel-build`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot requested review from derekwaynecarr and juanvallejo February 18, 2019 10:42

xichengliudui mentioned this pull request Feb 18, 2019

Eliminate shellcheck failures #72956

Closed

k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 18, 2019

xichengliudui force-pushed the fixshellcheck19021803 branch from 933a839 to 378251f Compare February 18, 2019 10:48

fix shellcheck in hack/... and pkg/... and staging/src/k8s.io/metrics…

ca2bc4b

…/hack/... update pull request update pull request update pull request update pull request update pull request update pull request update pull request update pull request

k8s-ci-robot assigned BenTheElder Feb 19, 2019

BenTheElder reviewed Feb 19, 2019

View reviewed changes

xichengliudui force-pushed the fixshellcheck19021803 branch from 378251f to fd86907 Compare February 19, 2019 08:52

BenTheElder reviewed Feb 19, 2019

View reviewed changes

xichengliudui force-pushed the fixshellcheck19021803 branch from fd86907 to 957192b Compare February 20, 2019 02:01

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2019

BenTheElder approved these changes Feb 20, 2019

View reviewed changes

spiffxp reviewed Feb 20, 2019

View reviewed changes

plugin/pkg/admission/imagepolicy/gencerts.sh Outdated Show resolved Hide resolved

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019

xichengliudui force-pushed the fixshellcheck19021803 branch from 8cbebd4 to 957192b Compare February 21, 2019 02:19

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2019

xichengliudui force-pushed the fixshellcheck19021803 branch from 957192b to b1fac2a Compare February 21, 2019 02:20

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2019

k8s-ci-robot assigned cblecker, deads2k, lavalamp and piosz Feb 22, 2019

k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019

cblecker added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2019

xichengliudui force-pushed the fixshellcheck19021803 branch 2 times, most recently from db8ff08 to bc6bff4 Compare February 23, 2019 09:37

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2019

xichengliudui force-pushed the fixshellcheck19021803 branch 2 times, most recently from 9be1273 to ca2bc4b Compare February 23, 2019 09:50

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2019

xichengliudui closed this Feb 23, 2019

xichengliudui deleted the fixshellcheck19021803 branch February 23, 2019 10:15

xichengliudui mentioned this pull request Feb 23, 2019

fix shellcheck in hack/... #74451

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix shellcheck in hack/... and pkg/... and staging/... #74205

fix shellcheck in hack/... and pkg/... and staging/... #74205

xichengliudui commented Feb 18, 2019 •

edited

xichengliudui commented Feb 18, 2019

xichengliudui commented Feb 18, 2019

xichengliudui commented Feb 19, 2019

BenTheElder Feb 19, 2019

xichengliudui Feb 19, 2019

BenTheElder Feb 19, 2019

xichengliudui Feb 20, 2019

BenTheElder left a comment

xichengliudui commented Feb 20, 2019

spiffxp Feb 20, 2019

xichengliudui Feb 21, 2019 •

edited

mrbobbytables Feb 21, 2019

xichengliudui Feb 21, 2019

spiffxp Feb 22, 2019

k8s-ci-robot commented Feb 21, 2019

xichengliudui commented Feb 21, 2019

xichengliudui commented Feb 22, 2019

spiffxp commented Feb 22, 2019

k8s-ci-robot commented Feb 23, 2019

xichengliudui commented Feb 23, 2019

k8s-ci-robot commented Feb 23, 2019 •

edited

		--output-base "$(dirname "${BASH_SOURCE[0]}")/../../.." \
		--go-header-file "${SCRIPT_ROOT}"/hack/boilerplate.go.txt

fix shellcheck in hack/... and pkg/... and staging/... #74205

fix shellcheck in hack/... and pkg/... and staging/... #74205

Conversation

xichengliudui commented Feb 18, 2019 • edited

xichengliudui commented Feb 18, 2019

xichengliudui commented Feb 18, 2019

xichengliudui commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BenTheElder left a comment

Choose a reason for hiding this comment

xichengliudui commented Feb 20, 2019

Choose a reason for hiding this comment

xichengliudui Feb 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 21, 2019

xichengliudui commented Feb 21, 2019

xichengliudui commented Feb 22, 2019

spiffxp commented Feb 22, 2019

k8s-ci-robot commented Feb 23, 2019

xichengliudui commented Feb 23, 2019

k8s-ci-robot commented Feb 23, 2019 • edited

xichengliudui commented Feb 18, 2019 •

edited

xichengliudui Feb 21, 2019 •

edited

k8s-ci-robot commented Feb 23, 2019 •

edited