Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to use dynamic shared informer for Garbage Collector. #74440

Merged
merged 1 commit into from
May 18, 2019
Merged

Switched to use dynamic shared informer for Garbage Collector. #74440

merged 1 commit into from
May 18, 2019

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Feb 22, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Switched to use dynamic shared informer for Garbage Collector.

Which issue(s) this PR fixes:

prerequisite for #53777
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 22, 2019
@yliaog yliaog force-pushed the dynamic branch 2 times, most recently from 9dfd111 to cf829a5 Compare February 23, 2019 00:02
@roycaihw
Copy link
Member

/assign @caesarxuchao

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 7, 2019
caesarxuchao
caesarxuchao reviewed Mar 9, 2019
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for a nit.

pkg/controller/garbagecollector/garbagecollector_test.go Outdated Show resolved Hide resolved
@yliaog yliaog changed the title WIP: Switched to use dynamic shared informer for Garbage Collector. Switched to use dynamic shared informer for Garbage Collector. Mar 12, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2019
caesarxuchao
caesarxuchao reviewed Mar 12, 2019
View reviewed changes
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

pkg/controller/garbagecollector/garbagecollector_test.go Outdated
@@ -60,6 +62,7 @@ func TestGarbageCollectorConstruction(t *testing.T) {
tweakableRM := meta.NewDefaultRESTMapper(nil)
rm := &testRESTMapper{meta.MultiRESTMapper{tweakableRM, testrestmapper.TestOnlyStaticRESTMapper(legacyscheme.Scheme)}}
dynamicClient, err := dynamic.NewForConfig(config)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the extra new line.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2019
@yliaog
Copy link
Contributor Author

yliaog commented Apr 2, 2019

/cc @liggitt @deads2k

@liggitt liggitt mentioned this pull request Apr 7, 2019
Closed
@yliaog
Copy link
Contributor Author

yliaog commented Apr 15, 2019

@liggitt @deads2k could you please review and if ok approve? Thanks

@yliaog
Copy link
Contributor Author

yliaog commented Apr 23, 2019

/assign @liggitt @deads2k

@deads2k
Copy link
Contributor

deads2k commented Apr 29, 2019

I really like how well this fell out. I need to spend a few minutes tomorrow double checking tests. @yliaog you could save me a few minutes by linking me to the test checking GC of a CRD.

@yliaog
Copy link
Contributor Author

yliaog commented Apr 29, 2019

the three test cases below in the integration test are for CRD. Thanks.

TestCustomResourceCascadingDeletion:
https://github.com/kubernetes/kubernetes/blob/9606fa5d87d58a5a1387336c67639d5825a64640/test/integration/garbagecollector/garbage_collector_test.go#L806

TestMixedRelationships:
https://github.com/kubernetes/kubernetes/blob/9606fa5d87d58a5a1387336c67639d5825a64640/test/integration/garbagecollector/garbage_collector_test.go#L866

TestCRDDeletionCascading:
https://github.com/kubernetes/kubernetes/blob/9606fa5d87d58a5a1387336c67639d5825a64640/test/integration/garbagecollector/garbage_collector_test.go#L964

@deads2k
Copy link
Contributor

deads2k commented Apr 30, 2019

I'd like to see a test that does a delete of the CRD (not the CR) and a recreate of the same CRD to be sure the logic works and correctly builds out the graph.

/approve
/hold

holding for the test. Feel free to release the hold once the test is present, I don't need a second look.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, deads2k, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2019
@caesarxuchao
Copy link
Member

caesarxuchao commented May 17, 2019 •
edited

I'd like to see a test that does a delete of the CRD (not the CR) and a recreate of the same CRD to be sure the logic works and correctly builds out the graph.

The test was added. @yliaog could you note down the issue the test discovered, and how it was fixed by #78029?

/hold remove
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@yliaog
Copy link
Contributor Author

yliaog commented May 17, 2019

/hold

wait for #78029 to merge

@yliaog
Copy link
Contributor Author

yliaog commented May 18, 2019

/retest
/hold remove

@yliaog
Copy link
Contributor Author

yliaog commented May 18, 2019

/hold remove

@yliaog
Copy link
Contributor Author

yliaog commented May 18, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0f31cc9 into kubernetes:master May 18, 2019
@liggitt liggitt mentioned this pull request May 30, 2019
Closed
@liggitt
Copy link
Member

liggitt commented May 30, 2019

TestStressingCascadingDeletion started flaking as soon as this PR was merged. See #78525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao caesarxuchao left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@caesarxuchao caesarxuchao

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yliaog @roycaihw @caesarxuchao @deads2k @k8s-ci-robot @liggitt