-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched to use dynamic shared informer for Garbage Collector. #74440
Conversation
9dfd111
to
cf829a5
Compare
/assign @caesarxuchao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for a nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@@ -60,6 +62,7 @@ func TestGarbageCollectorConstruction(t *testing.T) { | |||
tweakableRM := meta.NewDefaultRESTMapper(nil) | |||
rm := &testRESTMapper{meta.MultiRESTMapper{tweakableRM, testrestmapper.TestOnlyStaticRESTMapper(legacyscheme.Scheme)}} | |||
dynamicClient, err := dynamic.NewForConfig(config) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the extra new line.
/lgtm |
I really like how well this fell out. I need to spend a few minutes tomorrow double checking tests. @yliaog you could save me a few minutes by linking me to the test checking GC of a CRD. |
the three test cases below in the integration test are for CRD. Thanks. TestCustomResourceCascadingDeletion: TestMixedRelationships: TestCRDDeletionCascading: |
I'd like to see a test that does a delete of the CRD (not the CR) and a recreate of the same CRD to be sure the logic works and correctly builds out the graph. /approve holding for the test. Feel free to release the hold once the test is present, I don't need a second look. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, deads2k, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold wait for #78029 to merge |
/retest |
/hold remove |
/hold cancel |
TestStressingCascadingDeletion started flaking as soon as this PR was merged. See #78525 |
What type of PR is this?
What this PR does / why we need it:
Switched to use dynamic shared informer for Garbage Collector.
Which issue(s) this PR fixes:
prerequisite for #53777
Special notes for your reviewer:
Does this PR introduce a user-facing change?: