Terminate custom resource watches when storage is destroyed #78029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/priority critical-urgent this results in hung watch clients with O(hour) timeouts when CRDs change |
k8s-ci-robot
added
area/apiserver
priority/critical-urgent
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
liggitt
changed the title
This was referenced May 17, 2019
sttts
reviewed
May 17, 2019
sttts
reviewed
May 17, 2019
staging/src/k8s.io/apiserver/pkg/storage/cacher/cacher_whitebox_test.go
Outdated
Show resolved
Hide resolved
|
one nit. Otherwise lgtm. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Impacted how far back? |
10 tasks
This was referenced May 17, 2019
Watch cache at least back to 1.12 (I'd expect even further). Custom resources as far back as they used the watch cache (not sure how far that is) |
liggitt
added
priority/important-soon
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
fixed gofmt issue |
liggitt
added
the
lgtm
|
Looks right. Thanks for finding and fixing. /lgtm |
yliaog
reviewed
May 17, 2019
|
/lgtm |
liggitt
moved this from Required for GA, in progress
to Complete
in Custom Resource Definitions
k8s-ci-robot
added a commit
that referenced
this pull request
May 23, 2019
…9-upstream-release-1.12 Automated cherry pick of #78029: Terminate watchers when watch cache is destroyed
k8s-ci-robot
added a commit
that referenced
this pull request
May 31, 2019
…9-upstream-release-1.14 Automated cherry pick of #78029: Terminate watchers when watch cache is destroyed
k8s-ci-robot
added a commit
that referenced
this pull request
May 31, 2019
…9-upstream-release-1.13 Automated cherry pick of #78029: Terminate watchers when watch cache is destroyed
This was referenced Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
When a watch cache is stopped, drop all active watchers.
For normal resources, this only happens on apiserver shutdown. For custom resources, this happens whenever a CRD spec is changed, which currently strands active watchers.
Which issue(s) this PR fixes:
Fixes #74105
Fixes #71138
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @jpbetz @sttts