Check conformance test should not call any Skip

[oomichi]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Basically conformance test checks the target k8s cluster works all
features which are specified in each test and that should not depend
on any condition.
This adds checking that conformance test should not call any Skip
methods. And it detects the existing conformance test
"creating/deleting custom resource definition objects works"
calls framework.SkipUnlessServerVersionGTE().
This removes the Skip also.

Ref: #74432

Does this PR introduce a user-facing change?:

NONE

[oomichi]

pull-kubernetes-verify should detect it and be failed.

[oomichi]

/area conformance

[oomichi]

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76734/pull-kubernetes-verify/1118601635224883211

/home/prow/go/src/k8s.io/kubernetes/test/e2e//apimachinery/custom_resource_definition.go: Conformance test should not call any framework.Skip*()
Error: We need to fix the above errors.
exit status 1
Errors from lint:
Please review the above warnings.

[spiffxp]

/priority important-soon
/sig architecture
/sig testing

[spiffxp]

The Skip line in the offending test can definitely be removed.

var crdVersion = utilversion.MustParseSemantic("v1.7.0")
//...
framework.SkipUnlessServerVersionGTE(crdVersion, f.ClientSet.Discovery())

/approve

Now that you've used this PR to demonstrate that we're catching a Skip, remove it and we should see the verify job go green?

[oomichi]

@spiffxp

Now that you've used this PR to demonstrate that we're catching a Skip, remove it and we should see the verify job go green?

Yep, right. I wanted to demonstrate we can catch invalid usage of Skip in conformance tests and make a consensus that we should not have such Skip.
Let me remove it for passing the verifying job :-)

[oomichi]

/retest

[oomichi]

/retest

[oomichi]

@timothysc Hi, could you take a look at this again? I have fixed your point, I think.

[spiffxp]

/lgtm

[timothysc]

@oomichi lgtm I put you in the approval column waiting on final approval.

[oomichi]

@timothysc

lgtm I put you in the approval column waiting on final approval.

I guess you are saying 'cncf-k8s-conformance-wg' needs to approve this before merging, right?

[spiffxp]

/uncc

[timothysc]

/assign @bgrant0607 @smarterclayton

[smarterclayton]

/hold cancel

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, smarterclayton, spiffxp, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• hack/OWNERS [smarterclayton,spiffxp]
• test/OWNERS [smarterclayton,spiffxp,timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[smarterclayton]

A conformance 1.14 cluster is hitting this (a test is skipped). Going to try a cherry-pick to 1.14, and if it doesn't work will do a more targeted fix.

/cherrypick release-1.14

[smarterclayton]

Cherrypicked to #80598 manually, only the removal of the skips.