Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance should not skip tests in 1.14 #80598

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@smarterclayton
Copy link
Contributor

commented Jul 25, 2019

Kubernetes conformance tests are not allowed to skip. Backport the 1.15
change to 1.14.

Backports #76734 to 1.14 so conformant clusters can avoid a bug with
the kubectl describe test that only works when client and cluster
micro version are identical.

Fix a conformance test that was skipped when client had a newer micro version than server.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton changed the title Conformance should not skip tests Conformance should not skip tests in 1.14 Jul 25, 2019

@k8s-ci-robot k8s-ci-robot requested review from dixudx and enisoc Jul 25, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton force-pushed the smarterclayton:backport_skip branch 2 times, most recently from 1b6d56a to 23dbc7a Jul 25, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

@spiffxp spiffxp removed the cncf-cla: no label Jul 25, 2019

Conformance should not skip tests
Kubernetes conformance tests are not allowed to skip. Backport the 1.15
change to 1.14.

@smarterclayton smarterclayton force-pushed the smarterclayton:backport_skip branch from 23dbc7a to 4368fe6 Jul 25, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

/lgtm
/approve
/priority important-soon
/kind cleanup
/area conformance

@smarterclayton

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@kubernetes/release-managers this needs cherrypick approved for 1.14 to correct a bug in conformance tests

@bgrant0607

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, smarterclayton, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgrant0607 bgrant0607 moved this from Needs Approval to Done in cncf-k8s-conformance-wg Aug 6, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 7, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit cb900c7 into kubernetes:release-1.14 Aug 7, 2019

23 checks passed

cla/linuxfoundation smarterclayton authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Skipped.
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Skipped.
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.