-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance should not skip tests in 1.14 #80598
Conformance should not skip tests in 1.14 #80598
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@kubernetes/cncf-conformance-wg @johnbelamaric |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
1b6d56a
to
23dbc7a
Compare
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/80598/pull-kubernetes-e2e-gce/1154482369231589376/#0:build-log.txt%3A236 |
Kubernetes conformance tests are not allowed to skip. Backport the 1.15 change to 1.14.
23dbc7a
to
4368fe6
Compare
/lgtm |
@kubernetes/release-managers this needs cherrypick approved for 1.14 to correct a bug in conformance tests |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, smarterclayton, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
Kubernetes conformance tests are not allowed to skip. Backport the 1.15
change to 1.14.
Backports #76734 to 1.14 so conformant clusters can avoid a bug with
the kubectl describe test that only works when client and cluster
micro version are identical.