Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations #76994

Merged
merged 5 commits into from
Apr 27, 2019
Merged

Automated cherry pick of #76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations #76994

merged 5 commits into from
Apr 27, 2019

Conversation

feiskyer
Copy link
Member

Cherry pick of #76656 on release-1.12.

#76656: Switch to instance-level update APIs for Azure VMSS loadbalancer operations

Previously, VMSS API doesn't support configurations for each instance. Hence, Azure cloud provider upgrades manually for all instances whenever loadbalancer backend pools need to be updated. This would cause all instances restarted if there're also some other VMSS model changes.

To fix this issue, the PR switches to instance-level update APIs for Azure VMSS loadbalancer operations. It also upgrades Azure SDK to v21.4.0.

/kind bug
/priority critical-urgent
/sig azure

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Apr 24, 2019
@justaugustus
Copy link
Member

For SIG Azure & Release:
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2019
@feiskyer
Copy link
Member Author

/assign @tpepper @justaugustus @andyzhangx

/retest

@justaugustus
Copy link
Member

/assign @sttts @cblecker

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 24, 2019
andyzhangx
andyzhangx approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@andyzhangx
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-verify

@cblecker
Copy link
Member

verify failure is legitimate. please review and fix.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@feiskyer
Copy link
Member Author

@cblecker gofmt fixed now, I'm using a wrong Go version initially. PTAL

cblecker
cblecker reviewed Apr 25, 2019
View reviewed changes
Godeps/Godeps.json Outdated Show resolved Hide resolved
@feiskyer
Copy link
Member Author

/retest

1 similar comment
@feiskyer
Copy link
Member Author

/retest

@feiskyer
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@justaugustus justaugustus mentioned this pull request Apr 26, 2019
Closed
@justaugustus
Copy link
Member

Commented on the flake issue opened here: #73105 (comment)
/test pull-kubernetes-kubemark-e2e-gce-big

@justaugustus
Copy link
Member

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@feiskyer
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2019
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2019
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7a34e26 into kubernetes:release-1.12 Apr 27, 2019
@craiglpeters craiglpeters mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker cblecker left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

@sttts sttts

@cblecker cblecker

@tpepper tpepper

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@feiskyer @justaugustus @andyzhangx @cblecker @k8s-ci-robot @sttts @tpepper