Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta/v1 Table and PartialObjectMetadata objects #77136

Merged
merged 1 commit into from
May 2, 2019
Merged

Add meta/v1 Table and PartialObjectMetadata objects #77136

merged 1 commit into from
May 2, 2019

Conversation

smarterclayton
Copy link
Contributor

Part of promoting server side retrieval to GA.

/kind api-change

Promote meta.k8s.io/v1beta1 Table and PartialObjectMetadata to v1.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 26, 2019
@smarterclayton
Copy link
Contributor Author

/assign @liggitt

@smarterclayton smarterclayton mentioned this pull request Apr 26, 2019
Closed
4 tasks
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Apr 26, 2019
@smarterclayton smarterclayton force-pushed the add_v1_table_partial branch 2 times, most recently from 7e581b9 to 2d18512 Compare April 26, 2019 22:39
@smarterclayton
Copy link
Contributor Author

@lavalamp as well knowing that Jordan is busy.

This clones the APIs into v1, then changes the protobuf ids for v1 PartialObjectMetadataList to be consistent with others (we realized in 1.15 that v1beta1 was lacking ListMeta, so Items had already claimed id 1). In v1 the ids are flipped but we don't depend on proto ids for conversion and we don't store partial object metadata list.

@fedebongio
Copy link
Contributor

/assign @lavalamp

@smarterclayton
Copy link
Contributor Author

Pushed an update, I think I got all the comments.

@lavalamp
Copy link
Member

/approve

/retest

@smarterclayton
Add meta/v1 Table and PartialObjectMetadata objects
f95f1db 
Part of promoting server side retrieval to GA.
@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

OK, back to green with feedback addressed.

@liggitt
Copy link
Member

liggitt commented May 2, 2019

/lgtm
/approve
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ba28e0e into kubernetes:master May 2, 2019
@neolit123 neolit123 mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@enisoc enisoc Awaiting requested review from enisoc

@hongchaodeng hongchaodeng Awaiting requested review from hongchaodeng

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smarterclayton @fejta-bot @fedebongio @lavalamp @liggitt @k8s-ci-robot