Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify godeps failure on 1.14 #77239

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Fix verify godeps failure on 1.14 #77239

merged 1 commit into from
Apr 30, 2019

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Apr 29, 2019

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
github.com/evanphx/json-patch added a new tag at the same sha this
morning: https://github.com/evanphx/json-patch/releases/tag/v4.2.0

This confused godeps. This PR updates our file to match godeps
expectation.

Which issue(s) this PR fixes:
Fixes: #77238

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 29, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

/priority critical-urgent
/sig testing

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 29, 2019
@liggitt
Copy link
Member

liggitt commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 29, 2019
@liggitt
Copy link
Member

liggitt commented Apr 29, 2019

Do we need the same for 1.12 and 1.13?

@mtaufen
Fix verify godeps failure
9a816bc 
github.com/evanphx/json-patch added a new tag at the same sha this
morning: https://github.com/evanphx/json-patch/releases/tag/v4.2.0

This confused godeps. This PR updates our file to match godeps
expectation.

Fixes issue 77238
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Apr 29, 2019
@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

Yes, both use 5858425f75500d40c52783dce87d085a483ce135:

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

I'll send those too

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

1.12: #77240
1.13: #77241

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

/assign @dougm @aleksandra-malinowska @tpepper
Can one of you please approve the cherry-pick?

@mtaufen
Copy link
Contributor Author

mtaufen commented Apr 29, 2019

whoops that was for 1.13
/unassign @dougm
/assign @hoegaarden

@k8s-ci-robot k8s-ci-robot assigned hoegaarden and unassigned dougm Apr 29, 2019
@mtaufen mtaufen changed the title Fix verify godeps failure Fix verify godeps failure on 1.14 Apr 29, 2019
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 29, 2019
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cblecker
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit e9a577f into kubernetes:release-1.14 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@hoegaarden hoegaarden

@cblecker cblecker

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@mtaufen @liggitt @cblecker @k8s-ci-robot @dougm @hoegaarden @tpepper @aleksandra-malinowska