Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to #77247

Merged
merged 1 commit into from
May 9, 2019
Merged

Automated cherry pick of #77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to #77247

merged 1 commit into from
May 9, 2019

Conversation

qingling128
Copy link
Contributor

Cherry pick of #77224 on release-1.12.

#77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @qingling128. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2019
@qingling128
Copy link
Contributor Author

@MaciekPytel @mwielgus - Could someone help grant the /ok-to-test flag?

@qingling128
Copy link
Contributor Author

Friendly ping. Could someone help grant the /ok-to-test flag?

@MaciekPytel
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2019
@qingling128
Copy link
Contributor Author

/retest

@yujuhong
Copy link
Contributor

yujuhong commented May 6, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2019
@qingling128
Copy link
Contributor Author

/retest

@qingling128
Copy link
Contributor Author

Not sure if https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/77247/pull-kubernetes-verify/1125450643486543873 is intermittent.
Rerunning the tests.

@MaciekPytel - Can you approve this as cluster/gce/OWNERS? Seems like that bit is missing.

@feiskyer - (Found your name in the https://github.com/kubernetes/sig-release/blob/master/releases/release-1.12/release_team.md as the patch release manager). When is the last patch release cut for v1.12.9? We'd like to get this fix in. Wondering if we are still on track.

@yujuhong
Copy link
Contributor

yujuhong commented May 6, 2019

/assign @feiskyer
/assign @MaciekPytel

@yujuhong yujuhong removed their assignment May 6, 2019
@qingling128
Copy link
Contributor Author

@MaciekPytel @feiskyer - Friendly ping.

@MaciekPytel
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel, qingling128, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@qingling128
Copy link
Contributor Author

Thanks @MaciekPytel !

@feiskyer - Could you help with the do-not-merge/cherry-pick-not-approved label? BTW when is the last patch release cut for v1.12.9?

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 9, 2019
@feiskyer
Copy link
Member

feiskyer commented May 9, 2019

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 9, 2019
@feiskyer
Copy link
Member

feiskyer commented May 9, 2019

Could you help with the do-not-merge/cherry-pick-not-approved label? BTW when is the last patch release cut for v1.12.9?

cherry pick approved. v1.12.9 would probably be released on next next week.

@k8s-ci-robot k8s-ci-robot merged commit 1c74d93 into kubernetes:release-1.12 May 9, 2019
@qingling128 qingling128 deleted the automated-cherry-pick-of-#77224-upstream-release-1.12 branch May 9, 2019 03:42
@qingling128
Copy link
Contributor Author

@feiskyer - Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@feiskyer feiskyer

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qingling128 @k8s-ci-robot @MaciekPytel @yujuhong @feiskyer