Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Stackdriver Logging Agent addon image from 1.6.0 to 1.6.8 to fix segmentation fault bug. #77224

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@qingling128
Copy link
Contributor

commented Apr 29, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Upgrade Stackdriver Logging Agent addon image from 1.6.0 to 1.6.8 to fix segmentation fault bug.

Which issue(s) this PR fixes:

Fixes segmentation fault issue with Protobuf library when log entries are deeply nested.

Special notes for your reviewer:
The new Stackdriver addon pipeline has been removed from this repo. This PR is to back port this fix to the legacy pipeline so that customers who have not yet been able to migrate still get the segmentation fault fixed.

Does this PR introduce a user-facing change?:

Fixes segmentation fault issue with Protobuf library when log entries are deeply nested.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Hi @qingling128. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jingax10

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

/assign freehan

@jingax10

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

/ok-to-test

@freehan

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 29, 2019

@freehan

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

/assign bowei@ for approval

@bowei

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, freehan, qingling128

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Apr 30, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 62020eb into kubernetes:master Apr 30, 2019

20 checks passed

cla/linuxfoundation qingling128 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
k8s-ci-robot added a commit that referenced this pull request May 7, 2019
Merge pull request #77248 from qingling128/automated-cherry-pick-of-#…
…77224-upstream-release-1.13

Automated cherry pick of #77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to
k8s-ci-robot added a commit that referenced this pull request May 7, 2019
Merge pull request #77249 from qingling128/automated-cherry-pick-of-#…
…77224-upstream-release-1.14

Automated cherry pick of #77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to
k8s-ci-robot added a commit that referenced this pull request May 9, 2019
Merge pull request #77247 from qingling128/automated-cherry-pick-of-#…
…77224-upstream-release-1.12

Automated cherry pick of #77224: Upgrade Stackdriver Logging Agent addon image from 1.6.0 to
mm4tt added a commit to mm4tt/test-infra that referenced this pull request May 14, 2019
Revert fluentd-gcp version to 0.6-1.6.0-1 in gce-5000.
This is essentially reverting kubernetes/kubernetes#77224 in our gce 5000 performance tests.

We believe it may be related to kubernetes/kubernetes#76579
chases2 added a commit to chases2/test-infra that referenced this pull request Jun 4, 2019
Revert fluentd-gcp version to 0.6-1.6.0-1 in gce-5000.
This is essentially reverting kubernetes/kubernetes#77224 in our gce 5000 performance tests.

We believe it may be related to kubernetes/kubernetes#76579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.