-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some service tags not supported issues for Azure LoadBalancer service #77719
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-aks-engine-azure |
/test pull-kubernetes-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
@feiskyer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What type of PR is this?
What this PR does / why we need it:
Azure cloud provider has a limited support for service tags by annotations:
kubernetes/staging/src/k8s.io/legacy-cloud-providers/azure/azure_loadbalancer.go
Lines 96 to 97 in 32b37f5
But according to https://docs.microsoft.com/en-us/azure/virtual-network/security-overview#service-tags, there are actually much more service tags than this list. Hence, errors would happen if the service tag is not included in the above list.
This PR fixes the issue by removing the static list from the cloud provider and let Azure API validate whether the service tag is supported or not. If illegal service tags are provided, error events would be sent for the service.
Which issue(s) this PR fixes:
Fixes #77717
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig azure
/kind bug
/priority important-soon