Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kubectl delete pod busybox -o json work #78343

Closed
grosser opened this issue May 25, 2019 · 5 comments
Closed

make kubectl delete pod busybox -o json work #78343

grosser opened this issue May 25, 2019 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@grosser
Copy link

grosser commented May 25, 2019

I want to atomically delete an object and know it's last configuration.
DELETE api/v1/pod/NAME already returns the json, so please allow passing it back to the user.

@kubernetes/sig-cli-feature-requests

@grosser grosser added the kind/feature Categorizes issue or PR as related to a new feature. label May 25, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label May 25, 2019
@k8s-ci-robot
Copy link
Contributor

@grosser: Reiterating the mentions to trigger a notification:
@kubernetes/sig-cli-feature-requests

In response to this:

I want to atomically delete an object and know it's last configuration.
DELETE api/v1/pod/NAME already returns the json, so please allow passing it back to the user.

@kubernetes/sig-cli-feature-requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented May 25, 2019

Not all delete methods return object json, so kubectl could not implement this consistently

@grosser
Copy link
Author

grosser commented May 26, 2019 via email

@liggitt
Copy link
Member

liggitt commented Jun 4, 2019

Which ones don't ?

these don't:

  • APIService
  • AuditSink
  • CertificateSigningRequest
  • ClusterRole
  • ClusterRoleBinding
  • ConfigMap
  • ControllerRevision
  • CronJob
  • CustomResourceDefinition (and custom resources)
  • DaemonSet
  • Deployment
  • Endpoint
  • Event
  • HorizontalPodAutoscaler
  • Ingress
  • Job
  • Lease
  • LimitRange
  • MutatingWebhookConfiguration
  • NetworkPolicy
  • Node
  • PodDisruptionBudget
  • PodPreset
  • PriorityClass
  • ReplicaSet
  • ReplicationController
  • Role
  • RoleBinding
  • RuntimeClass
  • Secret
  • Service
  • StatefulSet
  • ValidatingWebhookConfiguration

these do:

  • CSIDriver
  • CSINode
  • Namespace
  • PersistentVolume
  • PersistentVolumeClaim
  • Pod
  • PodSecurityPolicy
  • ResourceQuota
  • ServiceAccount
  • StorageClass
  • VolumeAttachment

I'd still prefer if it was possible for the ones where it returns Json.

the wait behavior associated with delete makes it fairly difficult to do... since we can't do it consistently across resources, I'm not hugely in favor of it.

@grosser
Copy link
Author

grosser commented Jun 4, 2019

oh boy, did not expect it to be that complicated :(

@grosser grosser closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Development

No branches or pull requests

3 participants