have a saner default value of --terminated-pod-gc-threshold

[nikopen]

controller-manager 's config flag --terminated-pod-gc-threshold currently has a default value of 12500 - that's quite a lot!

/sig apps
/kind bug

[ellieayla]

Reference

kubernetes/pkg/controller/podgc/config/v1alpha1/defaults.go

Lines 23 to 31 in c48ed1c

	// RecommendedDefaultPodGCControllerConfiguration defaults a pointer to a
	// PodGCControllerConfiguration struct. This will set the recommended default
	// values, but they may be subject to change between API versions. This function
	// is intentionally not registered in the scheme as a "normal" `SetDefaults_Foo`
	// function to allow consumers of this type to set whatever defaults for their
	// embedded configs. Forcing consumers to use these defaults would be problematic
	// as defaulting in the scheme is done as part of the conversion, and there would
	// be no easy way to opt-out. Instead, if you want to use this defaulting method
	// run it in your wrapper struct of this type in its `SetDefaults_` method.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[hpandeycodeit]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[hpandeycodeit]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[blind3dd]

/reopen

[k8s-ci-robot]

@blind3dd: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qiutongs]

/reopen

[k8s-ci-robot]

@qiutongs: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@nikopen: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[qiutongs]

Revive this issue and see if we can come up with a more reasonable default value for the threshold.

[qiutongs]

Job controller currently relies on Pods not being removed to keep track of completions. #28486

Therefore it seems we'd better keep the current threshold before fixing that issue.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/reopen
as this is still relevant in the future.

[k8s-ci-robot]

@alculquicondor: Reopened this issue.

In response to this:

/reopen
as this is still relevant in the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dlouzan]

@qiutongs Since #98238 implemented better job tracking in 1.22, should this be reopened and a saner default be applied? 12500 still feels like quite a lot.

/cc @nikopen

[alculquicondor]

I'm no longer sure that changing the default is a good idea. Users might be relying on this. For example, I'm aware that Argo requires the pod to also stay in the API to do its accounting.

If you are sure that your cluster doesn't have these problems, why not change the value on your end?

[dlouzan]

@alculquicondor Hey, thanks for the answer. Not an issue on our end, we can ofc modify the defaults. It's even mentioned on the CIS hardening for k3s, as this might be a too-high value for certain environments.

But since I don't know all implications of that change, and the docs do not explain it in detail, this feedback is actually kind-of what I was looking for 😀