1.13: Fix incorrect procMount defaulting #78882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
liggitt
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/kind bug |
k8s-ci-robot
added
kind/bug
janetkuo
approved these changes
Jun 11, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
tpepper
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
Hi, I've installed v1.13.7 and I'm still getting the same failure listed in #69356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes incorrect forcing of the alpha procMount field to a non-nil value.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):xref #78633
See similar discussion around impact of defaulting fields within pod spec on workload controllers in #69988 and #69445.
Special notes for your reviewer:
This PR allows objects without the alpha field set to remain nil. This prevents unrelated updates to a workload object (like annotating it) from modifying the pod spec portion of the object and forcing a spurious rollout.
This also updates the fixtures used in the workload upgrade tests that would have caught this issue.
Similar changes are required in 1.12 and 1.14.
Release note:
/sig apps
/cc @janetkuo @smarterclayton
/priority critical-urgent