Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating github.com/go-bindata/go-bindata to v3.1.1 #79230

Merged
merged 1 commit into from
Jun 21, 2019
Merged

updating github.com/go-bindata/go-bindata to v3.1.1 #79230

merged 1 commit into from
Jun 21, 2019

Conversation

dims
Copy link
Member

@dims dims commented Jun 20, 2019

Change-Id: I66c047a4e5e72632042f43a9f4b33ab9f5bf7ef1

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
https://github.com/jteeuwen/go-bindata is now archived by its owner. Contributors have created a new org and are working there https://github.com/go-bindata/go-bindata

So we should switch to code from the new repo.

Which issue(s) this PR fixes:

Fixes #79229

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@dims
updating github.com/go-bindata/go-bindata to v3.1.1
df3f9f1 
Change-Id: I66c047a4e5e72632042f43a9f4b33ab9f5bf7ef1
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 20, 2019
@dims
Copy link
Member Author

dims commented Jun 20, 2019 •
edited

/assign @cblecker @seans3

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 20, 2019
@dims
Copy link
Member Author

dims commented Jun 20, 2019

/unassign @derekwaynecarr

@cblecker
Copy link
Member

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@dims
Copy link
Member Author

dims commented Jun 21, 2019

/assign @thockin @liggitt

(for root approval as we touch go.* files)

thockin
thockin reviewed Jun 21, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit baa5293 into kubernetes:master Jun 21, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@warmchang warmchang mentioned this pull request Aug 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@cblecker cblecker Awaiting requested review from cblecker

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Move from jteeuwen/go-bindata to go-bindata/go-bindata
6 participants
@dims @cblecker @k8s-ci-robot @thockin @liggitt @derekwaynecarr