Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add meta Table tests, fix --watch-only with single item #79345

Merged
merged 4 commits into from
Jun 28, 2019
Merged

Add meta Table tests, fix --watch-only with single item #79345

merged 4 commits into from
Jun 28, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes kubectl get --watch-only with table output when watching a single item. Column headers are only included in the first watch event, which we suppressed printing. That meant no columns were defined for subsequent events.

Does this PR introduce a user-facing change?:

Fixes output of `kubectl get --watch-only` when watching a single resource

/sig cli
/cc @smarterclayton

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl labels Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2019
@liggitt
Copy link
Member Author

liggitt commented Jun 25, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 25, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@liggitt
Copy link
Member Author

liggitt commented Jun 26, 2019

/assign @seans3

@liggitt
Copy link
Member Author

liggitt commented Jun 26, 2019

/assign @soltysh

@seans3
Copy link
Contributor

seans3 commented Jun 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4745946 into kubernetes:master Jun 28, 2019
@liggitt liggitt deleted the kubectl-printing branch June 28, 2019 15:31
@smarterclayton
Copy link
Contributor

/approve

retroactively

and also lgtm

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@soltysh soltysh

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liggitt @k8s-ci-robot @seans3 @smarterclayton @soltysh