Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimiter context aware and fix request may hang issue #79375

Merged
merged 1 commit into from
Jun 28, 2019
Merged

RateLimiter context aware and fix request may hang issue #79375

merged 1 commit into from
Jun 28, 2019

Conversation

answer1991
Copy link
Contributor

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

  1. RateLimiter add a context-aware method which is really necessary in async scene
  2. fix client-go request goruntine backlog in async scene

Which issue(s) this PR fixes:

Fixes #78766

Special notes for your reviewer:

The new method added in RateLimiter called Wait, it's context-aware, which is recommended to replace method Accept if the caller has context.

Does this PR introduce a user-facing change?:

Interface RateLimiter in client-go/util/flowcontrol package add a context-aware method called Wait.

RateLimiter add a context-aware method, fix client-go request goruntine backlog in async timeout scene.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @answer1991. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2019
draveness
draveness suggested changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/priority backlog

staging/src/k8s.io/client-go/rest/config_test.go Show resolved Hide resolved
staging/src/k8s.io/client-go/rest/request.go Show resolved Hide resolved
staging/src/k8s.io/client-go/rest/request.go Outdated Show resolved Hide resolved
staging/src/k8s.io/client-go/rest/request.go Outdated Show resolved Hide resolved
staging/src/k8s.io/client-go/util/flowcontrol/throttle.go Show resolved Hide resolved
staging/src/k8s.io/client-go/util/flowcontrol/throttle.go Show resolved Hide resolved
staging/src/k8s.io/client-go/util/flowcontrol/throttle_test.go Outdated Show resolved Hide resolved
staging/src/k8s.io/client-go/util/flowcontrol/throttle_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2019
@answer1991 answer1991 force-pushed the feature/flow-control-context-aware branch from 33ec23d to ce8805f Compare June 25, 2019 17:00
@answer1991
Copy link
Contributor Author

/reset

@zhangxiaoyu-zidif
Copy link
Contributor

/retest

@fedebongio
Copy link
Contributor

/assign @aaron-prindle

@yliaog
Copy link
Contributor

yliaog commented Jun 27, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog June 27, 2019 20:07
@liggitt
Copy link
Member

liggitt commented Jun 27, 2019

based on POC in liggitt@08dbd4e

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 46667d0 into kubernetes:master Jun 28, 2019
tedyu
tedyu reviewed Jun 28, 2019
View reviewed changes
staging/src/k8s.io/client-go/util/flowcontrol/throttle.go
@@ -141,3 +153,7 @@ func (t *fakeNeverRateLimiter) Accept() {
func (t *fakeNeverRateLimiter) QPS() float32 {
return 1
}

func (t *fakeNeverRateLimiter) Wait(ctx context.Context) error {
return errors.New("can not be accept")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can not be accept -> cannot be accepted

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@liggitt liggitt mentioned this pull request Oct 10, 2019
Closed
@liggitt liggitt mentioned this pull request Nov 16, 2019
Closed
@mikedanese mikedanese mentioned this pull request Dec 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedyu tedyu tedyu left review comments

@draveness draveness draveness requested changes

@liggitt liggitt Awaiting requested review from liggitt

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@liggitt liggitt

@aaron-prindle aaron-prindle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

goruntine leak if we use client-go in async timeout scene
9 participants
@answer1991 @k8s-ci-robot @zhangxiaoyu-zidif @fedebongio @yliaog @liggitt @tedyu @draveness @aaron-prindle