Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration shim for verifyvolumeattachment and bulk verify #80443

Merged
merged 1 commit into from Jul 24, 2019
Merged

Add migration shim for verifyvolumeattachment and bulk verify #80443

merged 1 commit into from Jul 24, 2019

Conversation

davidz627
Copy link
Contributor

VerifyVolumesAreAttached and BulkVolumeVerify were not shimmed to CSI when migration was enabled for the verification plugin. This implements the shim layer for those functions.

However, VerifyVolumesAreAttached for CSI is broken since it checks the VolumeAttachment object which is not currently necessarily representative of what's attached in the backend (if something was detached out of band VolumeAttachment wont see that). and BulkVolumeVerify is not implemented for CSI.

Those are separate issues that can be worked on after this PR.

/kind feature
/sig storage
/assign @msau42 @ddebroy @leakingtapan @saad-ali
/cc @gnufied @jsafrane @andrewsykim @adisky @andyzhangx

Add CSI Migration Shim for VerifyVolumesAreAttached and BulkVolumeVerify

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 22, 2019
@davidz627 davidz627 force-pushed the fix/verifyMigration branch 2 times, most recently from 7228ef0 to d0aaaf6 Compare July 22, 2019 23:36
@davidz627
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidz627

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@davidz627
Copy link
Contributor Author

/assign @jsafrane

@davidz627
Copy link
Contributor Author

/retest

jsafrane
jsafrane reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@jsafrane jsafrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only the logging looks too verbose.

pkg/volume/util/operationexecutor/operation_generator.go Outdated Show resolved Hide resolved
pkg/volume/util/operationexecutor/operation_generator.go Outdated Show resolved Hide resolved
@davidz627
Copy link
Contributor Author

/retest

1 similar comment
@davidz627
Copy link
Contributor Author

/retest

@davidz627
Copy link
Contributor Author

@jsafrane @msau42 comments addressed :)

@jsafrane
Copy link
Member

/lgtm
I think V(4) is OK.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot merged commit 030274e into kubernetes:master Jul 24, 2019
@davidz627 davidz627 deleted the fix/verifyMigration branch July 24, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@msau42 msau42 msau42 left review comments

@adisky adisky Awaiting requested review from adisky

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@jsafrane jsafrane

@leakingtapan leakingtapan

@saad-ali saad-ali

@ddebroy ddebroy

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@davidz627 @k8s-ci-robot @jsafrane @msau42 @leakingtapan @saad-ali @ddebroy