Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'apiserver_watch_events_sizes' #80477

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Add 'apiserver_watch_events_sizes' #80477

merged 1 commit into from
Aug 22, 2019

Conversation

mborsz
Copy link
Member

@mborsz mborsz commented Jul 23, 2019 •
edited

That metric can be used to estimate the size of watch events sent out to the clients.

The size of watch events can be used as an estimate of work done by apiserver.

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added a metric 'apiserver_watch_events_sizes' that can be used to estimate sizes of watch events in the system.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @wojtek-t

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 23, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2019
@wojtek-t
Copy link
Member

/assign @roycaihw @jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented Jul 23, 2019

/cc @logicalhan

@roycaihw
Copy link
Member

This requires a release note

@wojtek-t
Copy link
Member

This requires a release note

Why?

@mborsz
Add 'apiserver_watch_events_sizes'.
4af189a 
That metric can be used to estimate the size of watch events sent out to
the clients.
@roycaihw
Copy link
Member

roycaihw commented Aug 7, 2019

@wojtek-t The metrics endpoint is user-facing. Something similar to the notes in #78732 should work.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 7, 2019
@mborsz
Copy link
Member Author

mborsz commented Aug 7, 2019

I think release notes are a good idea in this case. I added some text. PTAL

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit ff1e112 into kubernetes:master Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@deads2k deads2k Awaiting requested review from deads2k

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@jpbetz jpbetz

@roycaihw roycaihw

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mborsz @wojtek-t @jpbetz @roycaihw @k8s-ci-robot @fejta-bot