Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 503 for custom resource requests during server start #81244

Merged
merged 1 commit into from Aug 14, 2019
Merged

Return 503 for custom resource requests during server start #81244

merged 1 commit into from Aug 14, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Aug 9, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:

Ensures that requests to potential custom resource endpoints while the server is starting get a 503 error, not a 404

Which issue(s) this PR fixes:
Fixes #71218

Does this PR introduce a user-facing change?:

Resolves a transient 404 response to custom resource requests during server startup

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2019
@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2019

/cc @jpbetz @smarterclayton @roycaihw

@liggitt
Copy link
Member Author

liggitt commented Aug 9, 2019

/sig api-machinery
/priority important-soon

will work on an integration test exercising this

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2019
@jpbetz
Copy link
Contributor

jpbetz commented Aug 9, 2019

This looks right. +1 for test.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2019
@liggitt liggitt changed the title WIP - Return 503 for custom resource requests during server start Return 503 for custom resource requests during server start Aug 12, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2019
@liggitt
Copy link
Member Author

liggitt commented Aug 12, 2019

comments addressed, added tests

@liggitt
Copy link
Member Author

liggitt commented Aug 12, 2019

flake #81238

/retest

@liggitt
Copy link
Member Author

liggitt commented Aug 12, 2019

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Aug 13, 2019

/retest

@jpbetz
Copy link
Contributor

jpbetz commented Aug 13, 2019

Did a pass. The negotiated error handling looks great.

Thanks for the comprehensive testing.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3f0a486 into kubernetes:master Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019
@liggitt liggitt deleted the crd_startup_503 branch August 14, 2019 20:28
@liggitt liggitt mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton requested changes

@jpbetz jpbetz Awaiting requested review from jpbetz

@roycaihw roycaihw Awaiting requested review from roycaihw

@sttts sttts Awaiting requested review from sttts

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

Transient 404 for custom resource after etcd restart
4 participants
@liggitt @k8s-ci-robot @jpbetz @smarterclayton