Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: kustomize-ux #81458

Merged
merged 1 commit into from
Aug 22, 2019
Merged

kubeadm: kustomize-ux #81458

merged 1 commit into from
Aug 22, 2019
+109 −55

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Aug 15, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds new flags to the kubeadm UX for a new feature that allows applying kustomize patches to static pod manifests generated by kubeadm. See KEP

Which issue(s) this PR fixes:
xref #kubernetes/kubeadm#1379

Special notes for your reviewer:
WRT to the POC [https://github.com//pull/80580] this PR:

  • contains only the core UX changes (core part already implemeted by Kubeadm: kustomize core #80905)
  • address all the feedbacks collected in the POC
  • contains minor improvements and fixes

Known limitations:
this first implementation as some known limitations:

  • it does not work with patches stored in a git repository
  • it does not support patchJson6902 patches

Does this PR introduce a user-facing change?:

NONE

/sig cluster-lifecycle
/priority important-soon
/assign @rosti @yagonobre @neolit123

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 15, 2019
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm labels Aug 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019
rosti
rosti approved these changes Aug 15, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabriziopandini !
/lgtm
/hold
for further discussion, feel free to remove the hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 15, 2019
@neolit123
Copy link
Member

neolit123 commented Aug 15, 2019 •
edited

@fabriziopandini

Fixes #kubernetes/kubeadm#1379

i think we should keep the tracking issue open until the feature reaches GA (or?)
we should probably start listing the PRs and work in it.

Implement a new feature that allows applying kustomize patches to static pod manifests generated by kubeadm.

we added a similar (the same) release note here:
#80905

so i think the one for this PR should be NONE, i don't think the release notes tool ignores duplicates.

neolit123
neolit123 reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source code changes LGTM, thanks.

@neolit123 neolit123 mentioned this pull request Aug 15, 2019
Merged
yagonobre
yagonobre reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM

@yagonobre
Copy link
Member

/pull-kubernetes-kubemark-e2e-gce-big

@fabriziopandini
Copy link
Member Author

/pull-kubernetes-kubemark-e2e-gce-big
@rosti do you think we can get this merged?

@fabriziopandini
Copy link
Member Author

/pull-kubernetes-kubemark-e2e-gce-big

@fabriziopandini
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 19, 2019
@neolit123
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2019
ereslibre
ereslibre approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fabriziopandini!

/lgtm
/hold

Feel free to remove the hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2019
@fabriziopandini
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@neolit123 neolit123 mentioned this pull request Aug 22, 2019
Closed
@rosti
Copy link
Contributor

rosti commented Aug 22, 2019

This has been up for reviews for long enough.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
@neolit123
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit d54c516 into kubernetes:master Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 22, 2019
@fabriziopandini fabriziopandini deleted the kubeadm-kustomize-ux branch August 22, 2019 19:53
@alexeldeib alexeldeib mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@yagonobre yagonobre yagonobre left review comments

@ereslibre ereslibre ereslibre approved these changes

@rosti rosti rosti approved these changes

@kad kad Awaiting requested review from kad

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@ereslibre ereslibre

@neolit123 neolit123

@rosti rosti

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fabriziopandini @k8s-ci-robot @neolit123 @yagonobre @rosti @ereslibre