Fix a static check failure in controller-manager

[mnogu]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fix a static check failure in controller-manager

cmd/controller-manager/app/serve.go:65:25: prometheus.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead.  (SA1019)

Which issue(s) this PR fixes:

Ref: #81657

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Welcome @mnogu!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mnogu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ping035627]

/ok-to-test

[mnogu]

/remove-kind bug

[fedebongio]

/assign @cheftako

[SataQiu]

/approve
for hack

[mnogu]

ping @cheftako for approval

[cheftako]

Please take a look at #81624.
Seems like this may obviate you changes.

[mnogu]

Please take a look at #81624.
Seems like this may obviate you changes.

After merging #81624, I got this message:

cmd/controller-manager/app/serve.go:66:25: legacyregistry.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead.  (SA1019)

How about adding a line-based linter directive to cmd/controller-manager/app/serve.go like this?

        //lint:ignore SA1019 See the Metrics Stability Migration KEP
        mux.Handle("/metrics", legacyregistry.Handler())

[mnogu]

/retest

[cheftako]

/lgtm

[cheftako]

Ping me when 1.17 opens and I'll approve.

[mnogu]

Ping me when 1.17 opens and I'll approve.

@cheftako ping

The master branch is open for pull requests for 1.17.

[cheftako]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, mnogu, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/controller-manager/OWNERS [cheftako]
• hack/OWNERS [SataQiu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cheftako]

/retest