Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added OWNERS file for Topology Manager #81793

Merged
merged 1 commit into from Sep 12, 2019
Merged

Added OWNERS file for Topology Manager #81793

merged 1 commit into from Sep 12, 2019

Conversation

lmdaly
Copy link
Contributor

@lmdaly lmdaly commented Aug 22, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Adds OWNERS file for Topology Manager

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot
Copy link
Contributor

@lmdaly: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @lmdaly. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Aug 22, 2019

@ConnorDoyle @klueska @nolancon

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2019
@lmdaly lmdaly mentioned this pull request Aug 22, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 22, 2019
@klueska
Copy link
Contributor

klueska commented Aug 22, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2019
mattjmcnaughton
mattjmcnaughton reviewed Aug 23, 2019
View reviewed changes
Copy link
Contributor

@mattjmcnaughton mattjmcnaughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a high level thought from me, but feel free to ignore if its not pertinent.

pkg/kubelet/cm/topologymanager/OWNERS
@@ -0,0 +1,7 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want sig-node approvers to be approvers here? Only 4 people in the approvers group strikes me as slightly small... especially in the 1-2 yr future when maybe this isn't being actively worked on, engs have left companies, etc...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC approvals are hierarchical, so any kubelet owner or kubelet/cm owner can also approve topology manager change.

@mattjmcnaughton
Copy link
Contributor

mattjmcnaughton commented Aug 24, 2019 via email

@lmdaly
Copy link
Contributor Author

lmdaly commented Aug 28, 2019

@ConnorDoyle @mattjmcnaughton The OWNERS files are inherited unless the options._no_parent_owners: true is set.

Here's the snippet from https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md:

  • options: a map of options for how to interpret this OWNERS file, currently only one:
    • no_parent_owners: defaults to false if not present; if true, exclude parent OWNERS files.
      Allows the use case where a/deep/nested/OWNERS file prevents a/OWNERS file from having > any effect on a/deep/nested/bit/of/code

Also added @derekwaynecarr to the file, just waiting @nolancon's memeber request to go through,

@dims
Copy link
Member

dims commented Aug 28, 2019

weird to see unrelated staticcheck failure:

Errors from staticcheck:
vendor/k8s.io/apiserver/pkg/admission/configuration/configuration_manager.go:80:6: func newPoller is unused (U1000)

@dims
Copy link
Member

dims commented Aug 28, 2019

@lmdaly can you please rebase to latest master and let's see if it happens again?

@lmdaly
Copy link
Contributor Author

lmdaly commented Aug 28, 2019 •
edited

@lmdaly can you please rebase to latest master and let's see if it happens again?

@dims Rebased!

@klueska
Copy link
Contributor

klueska commented Aug 30, 2019

/retest

@klueska
Copy link
Contributor

klueska commented Aug 30, 2019

/verify-owners

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 30, 2019
@klueska
Copy link
Contributor

klueska commented Aug 30, 2019

/release-note-none

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 30, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Sep 2, 2019

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 2, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 11, 2019
@lmdaly
Copy link
Contributor Author

lmdaly commented Sep 11, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@ConnorDoyle
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ConnorDoyle, lmdaly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@ConnorDoyle
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@klueska
Copy link
Contributor

klueska commented Sep 11, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 11, 2019
@klueska
Copy link
Contributor

klueska commented Sep 11, 2019

/retest

1 similar comment
@klueska
Copy link
Contributor

klueska commented Sep 11, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 07cc813 into kubernetes:master Sep 12, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorDoyle ConnorDoyle ConnorDoyle left review comments

@mattjmcnaughton mattjmcnaughton mattjmcnaughton left review comments

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@ConnorDoyle ConnorDoyle

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lmdaly @k8s-ci-robot @klueska @mattjmcnaughton @dims @ConnorDoyle