Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup ginkgo.Fail calls from the e2e test framework #81939

Closed
neolit123 opened this issue Aug 26, 2019 · 6 comments · Fixed by #81948
Closed

cleanup ginkgo.Fail calls from the e2e test framework #81939

neolit123 opened this issue Aug 26, 2019 · 6 comments · Fixed by #81948
Assignees
@beautytiger
Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@neolit123
Copy link
Member

/help
/kind cleanup
/area e2e-testing-framework

mini guide:
@neolit123 neolit123 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 26, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2019
@neolit123
Copy link
Member Author

/remove-kind feature
/area e2e-test-framework

@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework and removed kind/feature Categorizes issue or PR as related to a new feature. labels Aug 26, 2019
@neolit123 neolit123 mentioned this issue Aug 26, 2019
Merged
@neolit123
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2019
@beautytiger
Copy link

@neolit123
I will take this.

@alejandrox1
Copy link
Contributor

@beautytiger thank you!
Please feel free to ping #testing-commons in the Kubernetes slack if you have any questions 😃
/cc

@beautytiger beautytiger mentioned this issue Aug 26, 2019
Merged
@RainbowMango
Copy link
Member

RainbowMango commented Aug 28, 2019 •
edited

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 28, 2019
@RainbowMango
Copy link
Member

/assign @beautytiger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beautytiger beautytiger

Labels
area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup ginkgo.Fail calls from the e2e test framework beautytiger/kubernetes
5 participants
@neolit123 @alejandrox1 @RainbowMango @k8s-ci-robot @beautytiger