Unable to use go modules in device plugins

[cbf123]

What happened:

As described at k8snetworkplumbingwg/sriov-network-device-plugin#160 (comment) when I ran "go get k8s.io/kubernetes" it gave me the following error:

...initial bit snipped...
go: k8s.io/cluster-bootstrap@v0.0.0: unknown revision v0.0.0
go: k8s.io/kube-proxy@v0.0.0: unknown revision v0.0.0
go: k8s.io/code-generator@v0.0.0: unknown revision v0.0.0
go: k8s.io/metrics@v0.0.0: unknown revision v0.0.0
go: k8s.io/kubelet@v0.0.0: unknown revision v0.0.0
go: k8s.io/legacy-cloud-providers@v0.0.0: unknown revision v0.0.0
go: error loading module requirements

What you expected to happen:

That it would update the kubernetes dependency appropriately.

How to reproduce it (as minimally and precisely as possible):

git clone git@github.com:intel/sriov-network-device-plugin.git
cd sriov-network-device-plugin
go get k8s.io/kubernetes

Anything else we need to know?:

According to golang/go#32776 it might be a problem with specifying k8s.io/kubernetes as a dependency. At that link it says " k8s.io/kubernetes is not primarily intended to be consumed as a module. Only the published subcomponents are (and go get works properly with those)." If that's the case, then the deviceplugin API needs to be published as a subcomponent because clearly all device plugins need to be able to import the deviceplugin API.

[cbf123]

@kubernetes/sig-node-bugs

[k8s-ci-robot]

@cbf123: Reiterating the mentions to trigger a notification:
@kubernetes/sig-node-bugs

In response to this:

@kubernetes/sig-node-bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

/area code-organization

[dims]

Looks like the repo in question just uses code under k8s.io/kubernetes/pkg/kubelet/apis/deviceplugin, we could just move that to staging hopefully

[dims]

/assign @RenaudWasTaken

[dims]

note from @RenaudWasTaken in email:

We probably need to graduate the device plugin to v1 beforehand.

We expect changes in that api for the NUMA effort though so we might want to wait for the next release.

[andrewsykim]

/close

[k8s-ci-robot]

@andrewsykim: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.