Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote VolumeSubpathEnvExpansion to GA #82577

Closed
kevtaylor opened this issue Sep 11, 2019 · 9 comments
Closed

Promote VolumeSubpathEnvExpansion to GA #82577

kevtaylor opened this issue Sep 11, 2019 · 9 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@kevtaylor
Copy link
Contributor

kevtaylor commented Sep 11, 2019

Is this a BUG REPORT or FEATURE REQUEST?:
/kind api-change
/sig storage
/sig node
/milestone v1.17

Description:
This is the issue that is used to upgrade VolumeSubpathEnvExpansion feature gate to GA.

Related Issues:
Beta Upgrade: #76546
Feature Request: kubernetes/enhancements#559
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20181029-volume-subpath-env-expansion.md

@k8s-ci-robot
Copy link
Contributor

@kevtaylor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

Is this a BUG REPORT or FEATURE REQUEST?:
/kind api-change
/sig storage
/sig node
/milestone v1.17

Description:
This is the issue that is used to upgrade VolumeSubpathEnvExpansion feature gate to GA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 11, 2019
@kevtaylor
Copy link
Contributor Author

/assign @kevtaylor
/cc @msau42

@neolit123
Copy link
Member

please update kubernetes/enhancements#559 with the GA target.

@msau42
Copy link
Member

msau42 commented Oct 3, 2019

Should we also consider adding the e2e tests to the conformance suite (as a separate pr)? cc @kubernetes/cncf-conformance-wg

@kevtaylor
Copy link
Contributor Author

@msau42 Do you want me to put in a PR to switch the e2e tests to conformance level?
If so, just need some advice on that - seems like to just change It to ConformanceIt ?
Do we then need to leave the [sig-storage] tags - or remove them?
Any other additional tags that we need?

@johnbelamaric
Copy link
Member

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/conformance-tests.md

Please do that ASAP if you want it to make the release!

@johnbelamaric
Copy link
Member

You can leave the sig-storage tags

@msau42
Copy link
Member

msau42 commented Nov 11, 2019

sgtm!

@kevtaylor
Copy link
Contributor Author

This has been released now, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Development

No branches or pull requests

5 participants