Promote VolumeSubpathEnvExpansion feature gate to GA #82578

kevtaylor · 2019-09-11T12:05:20Z

/kind api-change

What this PR does / why we need it:
Promotes VolumeSubpathEnvExpansion feature gate to stable state
Which issue(s) this PR fixes:
Fixes ##82577

Special notes for your reviewer:
The beta state has been running since 1.15 with no reported issues.
No further tests/code changes identified

Does this PR introduce a user-facing change?:

The VolumeSubpathEnvExpansion feature is graduating to GA. The `VolumeSubpathEnvExpansion` feature gate is unconditionally enabled, and will be removed in v1.19.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:
[KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20181029-volume-subpath-env-expansion.md
[Usage]: kubernetes/website#13846
[Other doc]: kubernetes/enhancements#559

k8s-ci-robot · 2019-09-11T12:05:28Z

Hi @kevtaylor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2019-09-11T12:42:12Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

msau42 · 2019-09-11T23:00:39Z

/ok-to-test
/assign

kevtaylor · 2019-09-12T13:26:26Z

/test pull-kubernetes-e2e-gce-storage-slow

kevtaylor · 2019-09-13T06:41:04Z

/sig node
/sig storage

uzuku · 2019-09-26T08:57:10Z

Glad to see this feature comes to GA, it saves a lot of tricks in our logging mechanism.

msau42 · 2019-10-03T22:40:58Z

pkg/features/kube_features.go

@@ -299,7 +299,7 @@ const (
 	BalanceAttachedNodeVolumes featuregate.Feature = "BalanceAttachedNodeVolumes"

 	// owner: @kevtaylor
-	// beta: v1.15
+	// ga: v1.17


Add GA as a new line so we can easily see feature graduation history

Added graduation steps (I put the alpha one back in for completeness)

msau42 · 2019-10-03T22:42:33Z

pkg/features/kube_features.go

@@ -539,7 +539,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
 	CSIMigrationOpenStack:          {Default: false, PreRelease: featuregate.Alpha},
 	VolumeSubpath:                  {Default: true, PreRelease: featuregate.GA},
 	BalanceAttachedNodeVolumes:     {Default: false, PreRelease: featuregate.Alpha},
-	VolumeSubpathEnvExpansion:      {Default: true, PreRelease: featuregate.Beta},
+	VolumeSubpathEnvExpansion:      {Default: true, PreRelease: featuregate.GA},


I believe we should set LockToDefault: true and add a comment to remove the feature gate in +2 releases

msau42 · 2019-10-03T22:43:32Z

pkg/apis/core/types.go

@@ -1715,7 +1715,7 @@ type VolumeMount struct {
 	// Behaves similarly to SubPath but environment variable references $(VAR_NAME) are expanded using the container's environment.
 	// Defaults to "" (volume's root).
 	// SubPathExpr and SubPath are mutually exclusive.
-	// This field is beta in 1.15.
+	// This field is GA in 1.17.


I believe we don't comment on GA status in the types.go

msau42 · 2019-10-03T22:44:55Z

Also please add a release note that the feature is graduating to GA, and the feature gate is deprecated and will be removed in a future release

msau42 · 2019-10-03T22:49:01Z

/label api-review

liggitt · 2019-10-09T19:58:45Z

pkg/api/pod/util_test.go

@@ -1935,7 +1935,7 @@ func TestDropSubPathExpr(t *testing.T) {
 		},
 	}

-	for _, enabled := range []bool{true, false} {
+	for _, enabled := range []bool{true} {


drop the loop if it's not serving any purpose

liggitt · 2019-10-09T20:00:22Z

are the e2e tests getting run in default CI jobs? do we need to drop the [NodeFeature:VolumeSubpathEnvExpansion] tag?

kevtaylor · 2019-10-09T20:17:37Z

are the e2e tests getting run in default CI jobs? do we need to drop the [NodeFeature:VolumeSubpathEnvExpansion] tag?

I dont think these get run as defaults. We set the sig-storage tag so they run in the slow tests
and the NodeFeature to force them into the node e2e tests
so they get total coverage. Whether that's the best approach is debateable

msau42 · 2019-10-09T20:19:06Z

yes, they're running in gce and slow jobs (and pull-gce):
https://k8s-testgrid.appspot.com/sig-storage-kubernetes#gce&include-filter-by-regex=Variable
https://k8s-testgrid.appspot.com/sig-storage-kubernetes#gce-slow&include-filter-by-regex=Variable

As for node-e2es, they're not running in node-kubelet-master, but they are running in node-kubelet-features. Unsure what the criteria is for sig-node tests cc @kubernetes/sig-node-pr-reviews

https://k8s-testgrid.appspot.com/sig-node-kubelet#node-kubelet-features

liggitt · 2019-10-09T21:06:14Z

I think we typically take the feature tag off tests once they are not conditionally enabled. @kubernetes/sig-testing-pr-reviews might be able to confirm. Leaving the [Slow] tag on the slow tests is good.

BenTheElder · 2019-10-09T21:39:55Z

Yes - the Feature tag is meant to cover tests that we don't expect to be available on every cluster, eg the dashboard, podsecuritypolicy ...

kevtaylor · 2019-10-10T08:23:40Z

Yes - the Feature tag is meant to cover tests that we don't expect to be available on every cluster, eg the dashboard, podsecuritypolicy ...

I removed the Feature tag

kevtaylor · 2019-10-10T09:05:55Z

/test pull-kubernetes-e2e-gce-100-performance

kevtaylor · 2019-10-10T09:31:13Z

/test pull-kubernetes-e2e-gce-storage-slow

liggitt · 2019-10-10T12:13:09Z

/lgtm
/approve
/retest

k8s-ci-robot · 2019-10-10T12:13:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevtaylor, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [liggitt]
~~pkg/api/OWNERS~~ [liggitt]
~~pkg/apis/core/OWNERS~~ [liggitt]
~~pkg/features/OWNERS~~ [liggitt]
~~staging/src/k8s.io/api/OWNERS~~ [liggitt]
~~test/e2e/common/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kevtaylor · 2019-10-10T13:52:43Z

/retest

kevtaylor · 2019-10-10T14:02:50Z

/retest

…thEnvExpansion-GA Promote VolumeSubpathEnvExpansion feature gate to GA

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 11, 2019

k8s-ci-robot requested review from lavalamp and mwielgus September 11, 2019 12:07

k8s-ci-robot assigned msau42 Sep 11, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2019

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Sep 13, 2019

kevtaylor mentioned this pull request Sep 25, 2019

Promote VolumeSubpathEnvExpansion to GA kubernetes/website#16547

Merged

kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-GA branch from 5a265be to af7b1ae Compare September 30, 2019 07:52

kevtaylor mentioned this pull request Oct 2, 2019

Provide environment variables expansion in sub path mount kubernetes/enhancements#559

Closed

msau42 reviewed Oct 3, 2019

View reviewed changes

k8s-ci-robot added api-review Categorizes an issue or PR as actively needing an API review. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 3, 2019

liggitt added this to Assigned in API Reviews Oct 9, 2019

liggitt added this to the v1.17 milestone Oct 9, 2019

liggitt reviewed Oct 9, 2019

View reviewed changes

liggitt self-assigned this Oct 9, 2019

k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Oct 9, 2019

kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-GA branch from 3d29557 to 5d47750 Compare October 10, 2019 08:22

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2019

k8s-ci-robot added the area/test label Oct 10, 2019

Promote VolumeSubpathEnvExpansion feature gate to GA

cb8a7c1

kevtaylor force-pushed the kep/VolumeSubpathEnvExpansion-GA branch from 5d47750 to cb8a7c1 Compare October 10, 2019 08:34

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019

k8s-ci-robot merged commit cb1799b into kubernetes:master Oct 10, 2019

liggitt moved this from Assigned to API review completed, 1.17 in API Reviews Oct 11, 2019

ohsewon pushed a commit to ohsewon/kubernetes that referenced this pull request Oct 16, 2019

Merge pull request kubernetes#82578 from HotelsDotCom/kep/VolumeSubpa…

8b21be7

…thEnvExpansion-GA Promote VolumeSubpathEnvExpansion feature gate to GA

kevtaylor mentioned this pull request Nov 12, 2019

Promote e2e tests for VolumeSubpathEnvExpansion to Conformance #85122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote VolumeSubpathEnvExpansion feature gate to GA #82578

Promote VolumeSubpathEnvExpansion feature gate to GA #82578

kevtaylor commented Sep 11, 2019 •

edited by liggitt

k8s-ci-robot commented Sep 11, 2019

fejta-bot commented Sep 11, 2019

msau42 commented Sep 11, 2019

kevtaylor commented Sep 12, 2019

kevtaylor commented Sep 13, 2019

uzuku commented Sep 26, 2019

msau42 Oct 3, 2019

kevtaylor Oct 4, 2019

msau42 Oct 3, 2019

kevtaylor Oct 4, 2019

msau42 Oct 3, 2019

kevtaylor Oct 4, 2019

msau42 commented Oct 3, 2019

msau42 commented Oct 3, 2019

liggitt Oct 9, 2019

kevtaylor Oct 10, 2019

liggitt commented Oct 9, 2019

kevtaylor commented Oct 9, 2019

msau42 commented Oct 9, 2019

liggitt commented Oct 9, 2019

BenTheElder commented Oct 9, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

liggitt commented Oct 10, 2019

k8s-ci-robot commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

Promote VolumeSubpathEnvExpansion feature gate to GA #82578

Promote VolumeSubpathEnvExpansion feature gate to GA #82578

Conversation

kevtaylor commented Sep 11, 2019 • edited by liggitt

k8s-ci-robot commented Sep 11, 2019

fejta-bot commented Sep 11, 2019

msau42 commented Sep 11, 2019

kevtaylor commented Sep 12, 2019

kevtaylor commented Sep 13, 2019

uzuku commented Sep 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msau42 commented Oct 3, 2019

msau42 commented Oct 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liggitt commented Oct 9, 2019

kevtaylor commented Oct 9, 2019

msau42 commented Oct 9, 2019

liggitt commented Oct 9, 2019

BenTheElder commented Oct 9, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

liggitt commented Oct 10, 2019

k8s-ci-robot commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Oct 10, 2019

kevtaylor commented Sep 11, 2019 •

edited by liggitt