Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind kube-dns containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes #83358

Merged
merged 1 commit into from Jan 10, 2020
Merged

Bind kube-dns containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes #83358

merged 1 commit into from Jan 10, 2020

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Oct 1, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind cleanup

What this PR does / why we need it:

Bind kube-dns containers to linux nodes to avoid Windows scheduling, because the kube-dns container based on linux container not windows container

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Bind kube-dns containers to linux nodes to avoid Windows scheduling

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 1, 2019
@wawa0210 wawa0210 changed the title Bind kube-dns containers to linux nodes to avoid Windows scheduling Bind kube-dns containers to linux nodes to avoid Windows scheduling on kubernetes cluster includes linux nodes and windows nodes Oct 1, 2019
@wawa0210
Copy link
Contributor Author

wawa0210 commented Oct 1, 2019

/assign @bowei

@wawa0210
Copy link
Contributor Author

ping @bowei

@bowei
Copy link
Member

bowei commented Dec 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 6, 2019
@bowei
Copy link
Member

bowei commented Dec 6, 2019

cc: @kubernetes/sig-windows-misc
It would be good to get a sign off from someone on sig-windows.

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Dec 6, 2019
@wawa0210
Copy link
Contributor Author

wawa0210 commented Dec 7, 2019 •
edited

cc: @kubernetes/sig-windows-misc
It would be good to get a sign off from someone on sig-windows.

@liggitt @PatrickLang @andyzhangx @feiskyer

Hi guys, can you help review this pr. My mistake, the submission of months ago, has not been followed up

@k8s-ci-robot
Copy link
Contributor

@wawa0210: Reiterating the mentions to trigger a notification:
@kubernetes/sig-windows-misc

In response to this:

cc: @kubernetes/sig-windows-misc
It would be good to get a sign off from someone on sig-windows.

@liggitt @PatrickLang

Hi guys, can you help review this pr. My mistake, the submission of months ago, has not been followed up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pires
pires approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2019
@wawa0210
Copy link
Contributor Author

wawa0210 commented Dec 9, 2019

@feiskyer Can you help reivew this pr ?

feiskyer
feiskyer reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@wawa0210
Copy link
Contributor Author

wawa0210 commented Jan 9, 2020 •
edited

@bowei @MrHohn Can you approve this pr ? thanks so much

@wawa0210
Copy link
Contributor Author

wawa0210 commented Jan 9, 2020

#83364

MrHohn
MrHohn approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, MrHohn, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@PatrickLang PatrickLang added this to In Progress (v1.18) in SIG-Windows Jan 9, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0c02665 into kubernetes:master Jan 10, 2020
SIG-Windows automation moved this from In Progress (v1.18) to Done (v1.18) Jan 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 10, 2020
@wawa0210 wawa0210 deleted the zx-kubedns branch January 10, 2020 04:20
@wawa0210 wawa0210 mentioned this pull request Jan 17, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@pires pires pires approved these changes

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

Assignees

@feiskyer feiskyer

@bowei bowei

@pires pires

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wawa0210 @k8s-ci-robot @bowei @fejta-bot @feiskyer @pires @MrHohn