Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for unmanaged nodes for AWS cloud provider #83636

Closed
pisymbol opened this issue Oct 8, 2019 · 9 comments
Closed

Add support for unmanaged nodes for AWS cloud provider #83636

pisymbol opened this issue Oct 8, 2019 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.

Comments

@pisymbol
Copy link

pisymbol commented Oct 8, 2019

What would you like to be added:

I would like the AWS driver to support un-managed nodes like it does for Azure. See Issue #67984 for details.

Why is this needed:

The behavior is that unmanaged nodes just get automatically removed because the AWS cloud controller looks to the AWS API to determine if a node exists and to get an instance ID, but then it doesn't see it for unmanaged nodes thus it just removes it. This used to cause the scheduler to get stuck (but that was fixed in kubernetes/autoscaler#2235.

Can someone confirm that AWS has the same level of support as Azure regarding unmangaed nodes/issue #67984? We are running Kubernetes v1.13.

/platform/aws
/kind feature

@pisymbol pisymbol added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 8, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 8, 2019
@k8s-ci-robot
Copy link
Contributor

@pisymbol: The label(s) sig/aws cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

What would you like to be added:

I would like the AWS driver to support un-managed nodes like it does for Azure. See Issue #67984 for details.

Why is this needed:

We are seeing the scheduler get stuck when there are left over un-managed AWS nodes in a given AZ. We believe it is related to Issue #67984.

Can someone confirm that AWS has the same level of support as Azure regarding unmangaed nodes/issue #67984? We are running Kubernetes v1.13.

/sig aws
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@pisymbol: The label(s) sig/platform/aws cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

What would you like to be added:

I would like the AWS driver to support un-managed nodes like it does for Azure. See Issue #67984 for details.

Why is this needed:

We are seeing the scheduler get stuck when there are left over un-managed AWS nodes in a given AZ. We believe it is related to Issue #67984.

Can someone confirm that AWS has the same level of support as Azure regarding unmangaed nodes/issue #67984? We are running Kubernetes v1.13.

/sig platform/aws
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 9, 2019
@pisymbol
Copy link
Author

Updated issue description for clarity.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 8, 2020
@pisymbol
Copy link
Author

pisymbol commented Jan 8, 2020

IS there no interest in this at all?

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 7, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.
Projects
None yet
Development

No branches or pull requests

4 participants